thor.malmjursson wrote:

I'd disagree with this change. Indefinite simply means "for an undetermined period of time." - Indefinitely blocked users can be unblocked.

Infinite means that it will exist for infinity, basically until hell freezes over and Satan himself goes to work on Skis.

The two are very different, indefinite blocks are not permanent, although they are seen as such. An infinite block is just that. It never ends.

All core messages use indefinite, so there is no point changing the usage in an extension, without changing core aswell...

(In reply to comment #1)

I'd disagree with this change. Indefinite simply means "for an undetermined
period of time." - Indefinitely blocked users can be unblocked.

Infinite means that it will exist for infinity, basically until hell freezes
over and Satan himself goes to work on Skis.

The two are very different, indefinite blocks are not permanent, although they
are seen as such. An infinite block is just that. It never ends.

No. There's no difference between those blocks but the system messages; and trying to make a difference is simply wrong IMHO. The "unblock" button works fine with both of them so none of them are irreversible. Regards.

thor.malmjursson wrote:

I was referring to the words Indefinite and Infinite. They have entirely different meanings, and substituting one for the other does not work.

Ok, so here's what happens when displaying the block log:

• The block string is run through Language::translateBlockExpiry.
• This (in all languages except Finnish) looks at SpecialBlock::getSuggestedDurations which looks at the message 'ipboptions' - Which is the message used to give suggestion on the block page.
• In most languages, infinite is on this list, but indefinite is not, so infinite gets translated, while indefinite does not. (oddly enough on en, infinite is translated to indefnite, and indefinite is kept the same).

Since infinite, infinity, and indefinite are all taken to mean until the end of the world, I tend to agree they're equivalent. Furthermore we already translate infinite to indefinite, and so far no one has complained.

With that in mind I went ahead and made infinity/indefinite/infinite be treated as synonyms when translated in r88507 (1.19) [while not in Finnish, but every other lang]. I consider that much more the base issue than which word CheckUser uses.

Feel free to re-open if anyone thinks this is super-bad idea.