Page MenuHomePhabricator

Add image: Introduce end-to-end tests
Closed, ResolvedPublic

Description

During a retrospective of T309152: [regression-wmf.13] Add image: Missing "View image details" link , we discussed adding end-to-end tests for the add image feature.

To do that, we would have to:

  • Set up image suggestions in CI with a static suggester, similarly to how we have done for add link
    • (optionally) also introduce this in Patch Demo for QA'ing patches
  • Write a Selenium test that goes through the happy path for the add image workflow, including saving the edit

Event Timeline

Change 810912 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] [WIP] selenium: Add end-to-end test for add image workflow

https://gerrit.wikimedia.org/r/810912

Change 811774 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Test saving an edit for AddImage

https://gerrit.wikimedia.org/r/811774

Change 811919 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Verify that close button exists on mobile

https://gerrit.wikimedia.org/r/811919

kostajh changed the task status from Open to In Progress.Jul 29 2022, 12:59 PM
kostajh lowered the priority of this task from High to Medium.

Change 810912 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] selenium: Initial test for AddImage

https://gerrit.wikimedia.org/r/810912

Change 811919 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] selenium: Verify that close button exists on mobile

https://gerrit.wikimedia.org/r/811919

Change 811774 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Test saving an edit for AddImage

https://gerrit.wikimedia.org/r/811774

We'll have to come back to this one at another time, I think. Maybe as part of the Q2 testing initiative tasks.

Change 811774 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] selenium: Test saving an edit for AddImage

https://gerrit.wikimedia.org/r/811774

We'll have to come back to this one at another time, I think. Maybe as part of the Q2 testing initiative tasks.

Ah, indeed it's already captured in T312294: Add image: Create end-to-end test to verify saved content.

Urbanecm_WMF changed the task status from In Progress to Open.Oct 20 2022, 12:51 PM