Page MenuHomePhabricator

[Unplanned] Notification icon should not be red when there all notifications have been seen
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Login to any Wikimedia wiki from a mobile device
  • Produce a notification from another wiki (by editing the talk page from another account or any convenient way).
  • Go to any page from the mobile device and you will see that the notification icon has turned red. Now click on the red notification icon.
  • Go back and reload the page or go to a random page.

What happens?:

  • The notification icon still looks red.

What should have happened instead?:

  • After reload it should not be a red circle

Screenshot_20220610-182933~3.png (431×711 px, 57 KB)

Screenshot_20220610-184917~2.jpg (746×720 px, 100 KB)

Screenshot_20220610-184342~3.png (411×720 px, 79 KB)

Screenshot_20220610-184354~2.png (540×717 px, 102 KB)

QA Results - Prod

ACStatusDetails
1T310358#8506036

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Yes, I can also reproduce that. But, should not all wiki notifications be read by clicking ‘Mark as read’?

So I think the only bug here is the change of the number from 2 to 1?

firefox_yEwwHA6nUm.gif (183×414 px, 134 KB)

yeah that doesn't look right..

[...] should not all wiki notifications be read by clicking ‘Mark as read’?

I'd say so, yeah 🙂 though from memory Echo has done that for quite a while (i.e. "mark all as read" only marks local notifications read, not cross-wiki notifications)

Change 804601 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Pass Echo configuration to mobile

https://gerrit.wikimedia.org/r/804601

The setting of the notification number to 1 looks like an existing issue that does not relate to T301263. The patch above fixes it.

This might be related. Sorry, if this is not the right task.
There is another problem i found on bnwiki on mobile, you can reproduce it on test wiki too. On test wiki, from preferences, please change your interface language to bn (বাংলা). Now reload the page. Instead of showing (i have one notification right now), it first shows 1, then changes to . There is 1/2 second delay. This didn't happen before.

There is another problem i found on bnwiki on mobile, you can reproduce it on test wiki too. On test wiki, from preferences, please change your interface language to bn (বাংলা). Now reload the page. Instead of showing ১ (i have one notification right now), it first shows 1, then changes to ১. There is 1/2 second delay. This didn't happen before.

This sounds like a separate issue. I will take a look today.

Change 804601 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Pass Echo configuration to mobile

https://gerrit.wikimedia.org/r/804601

There is another problem i found on bnwiki on mobile, you can reproduce it on test wiki too. On test wiki, from preferences, please change your interfaclanguage to bn (বাংলা). Now reload the page. Instead of showing ১ (i have one notification right now), it first shows 1, then changes to ১. There is 1/2 second delay. This didn't happen before.

This sounds like a separate issue. I will take a look today.

Now tracked in T310537

This is still not right. The behaviour now, is that clicking notification icon converts it from red to gray. However, it seems on mobile the count should be notifications + alerts rather than just alerts 🤯. So I'm currently seeing the number go from red 1 to gray 2 on clicking a notifications overlay.

I'm working on a patch but probably need a few more days to do that.

One of the complexities here is that for Minerva the count is the number of notices plus the number of alerts as Minerva only shows one icon not 2. That wasn't obvious to me at first glance. I've opened T310559 to track this.

Unlicking this particular ticket, as it's about whether the notification icon should be gray on reload (desktop and mobile both behave this way).

I'm also experiencing this. For the last several days on Wikipedia in mobile mode the number of my unread alerts has been red, despite my having read them. Before this the number would turn to gray once any new alerts had been read and then marked unread.

This happens with both Firefox and Safari under macOS, and Safari under iOS. It does not happen in desktop mode, even under iOS on a phone. It also occurs not only on English Wikipedia, but also on Japanese and Italian Wikipedia, as well as Wiktionary, Wikisource, Wikimedia Commons, and Wikiquote (those are what I have tested so far), and I suspect all other Wikimedia projects. All OSes and browsers are up to date.

despite my having read them.

@DocWatson42 thanks for the report! When you say you have read them, do you mean you have clicked the blue circle or double tick button in the top right:

Screen Shot 2022-06-14 at 3.39.14 PM.png (562×1 px, 91 KB)

or do you mean you've clicked the red circle icon:

Screen Shot 2022-06-14 at 3.41.27 PM.png (116×116 px, 3 KB)

@Jdlrobson:

thanks for the report!

You're welcome. ^_^

When you say you have read them, do you mean you have clicked the blue circle or double tick button in the top right

Both, and then clicked the former blue circle (now a hollow circle) again so that it turns gray, and stays at the top of my notifications list. Well, I haven't tried clicking the buttons of old ones again (to turn them hollow) since the problem started, as some of them are years old, and retrieving them would be a pain.

@DocWatson42 I've been trying to replicate this without any luck I'm afraid. When I see the red circle,
click it, click the mark as read icon and reload the page the icon is no longer red.

Do you have any unread notices (e.g. from other wikis)? Perhaps mark all as read is not working on older notifications?

Would it be possible to share a screenshot or video as in the description of this task (make sure to cross out anything private)? Would it also be possible to get more information on what device you are using e.g. user agent. I am needing some kind of clue about your setup to debug this further.

Do you have any unread notices (e.g. from other wikis)?

I don't. (This started when I was in a conversation with another Wikipedia editor, so I was looking for the new notification.)

Perhaps mark all as read is not working on older notifications?

Perhaps, but it was until the date the first report above. (I've been keeping certain notices I've intended to do something about marked as unread.)

Would it be possible to share a screenshot or video as in the description of this task (make sure to cross out anything private)?

In the next few hours, sure.

Would it also be possible to get more information on what device you are using e.g. user agent. I am needing some kind of clue about your setup to debug this further.

iPhone 6S+ running iOS 15.5; Safari Version 15.5? (the software is up to date, but the Wikipedia article doesn't seem to be)

iMac Pro (2017) running macOS Monterey 12.4; Firefox 101.0.1; Safari Version 15.5 (confirmed via the browser itself, which is at odds with the Web sites I've just consulted)

kostajh renamed this task from It looks red even after clicking on the notification icon from the mobile device to Echo/Minerva: notification icon is red after clicking and reloading.Jun 16 2022, 7:20 AM

Would it be possible to share a screenshot or video as in the description of this task (make sure to cross out anything private)?

I'm sorry—I've procrastinated about doing this. What exactly do you need?

Ideally, a video showing you clicking the notification icon, marking the notifications as unread, reloading the page, and seeing it's still red. If not, screenshots as in the description of this task would be useful.

What you are describing sounds slightly different as you are clicking the mark as read button in step 2:
{F35247377}

Change 805485 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Add badge that combines notices and alerts

https://gerrit.wikimedia.org/r/805485

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/9225eb4c81/w/

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/9225eb4c81/w/

@Yahya @DocWatson42 it would be also helpful if you could review the https://patchdemo.wmflabs.org/wikis/9225eb4c81/w/ and let me know if the behaviour you see there is consistent with what you are expecting?

(sign it with username: Patch Demo and password: patchdemo1)

it would be also helpful if you could review the https://patchdemo.wmflabs.org/wikis/9225eb4c81/w/ and let me know if the behaviour you see there is consistent with what you are expecting?

Unfortunately that has apparently been deleted.

https://patchdemo.wmflabs.org/wikis/4f98097266/wiki/Main_Page

I'm sorry—those descriptions are above my head. I can report, however, that the situation has improved very slightly. When clicked the button now turns gray, until the tab is refreshed.

As posted above. [sigh] That was not happening for me until the last two or three days—for me, the button stayed red.

@DocWatson42 to clarify is this working as expected for you on production now? If so I think this was likely due to an issue with how we cache things our end.
I think I can close this ticket now, but please let me know if something still isn't working for you as expected.

I'm very sorry for any inconvenience this had to your workflow!

It's still not working. :-(

I'm very sorry for any inconvenience this had to your workflow!

It's not that big a deal—editing Wikipedia is one of my hobbies. That said, I'd still like to have it fixed, so that I can tell when a truly new alert arrives when I'm using Wikimedia projects on my phone (which is basically every day).

@DocWatson42 ah okay. So I think I'm misunderstanding something. Apologies if I'm repeating myself here, I just want to make sure I fully understand the problem.

This is the behaviour I am seeing and this all looks correct to me:

notifications.gif (796×595 px, 1 MB)

[Question 1] Does anything look wrong there, from your perspective?

[Question 2] Is the issue here that clicking the

Screen Shot 2022-06-28 at 4.49.34 PM.png (104×138 px, 4 KB)
button is not working for you? Are you seeing the black notification message at the bottom of the screen?

I don't have the check mark/ladder icon. Instead I have a "Mark all as read" text link/button. When I refresh after clicking the alerts/notifications button, the button turns red again (since I have four alerts I have deliberately re-marked as unread). The video is accurate up to that point.

I don't have the check mark/ladder icon. Instead I have a "Mark all as read" text link/button.

Okay now you have me very curious :-). Could you take a screenshot? I am not aware of a "mark all as read" text button in the default mobile interface, only the desktop interface.
Are you seeing something like this?

Screen Shot 2022-06-28 at 10.04.23 PM.png (112×1 px, 11 KB)

Reposting from my reply in the image (sub)thread:

That's ("Screen Shot 2022-06-28 at 10.04.23 PM.png") what it looked like, but now it's the ladder/check mark logo that was posted earlier. Possibly because I received a notification around that time.

Bumping this since I haven't seen any updates in a month and the problem is still present.

I don't. I was expecting that the attention given to this in the early days would continue, but apparently that is not the case. :-/ <sigh>

FWIW this bug will get worked on, it's just a matter of when. Right now both teams involved don't have capacity. Hope that's somewhat reassuring.

Okay—it is reassuring. Thank you. ^_^

Change 805485 abandoned by Jdlrobson:

[mediawiki/extensions/Echo@master] Add badge that combines notices and alerts

Reason:

Focusing on Vector 2022 for now.

https://gerrit.wikimedia.org/r/805485

Change 834614 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] WIP: Address issues with Minerva Echo icon

https://gerrit.wikimedia.org/r/834614

Change 867305 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Echo icon should reflect seen status

https://gerrit.wikimedia.org/r/867305

Change 834614 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] WIP: Address issues with Minerva Echo icon

Reason:

This has been split into https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/867305 https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/867304 and https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/867303

https://gerrit.wikimedia.org/r/834614

Jdlrobson renamed this task from Echo/Minerva: notification icon is red after clicking and reloading to Notification icon should not be read when there are seen notifications it should be gray.Dec 13 2022, 6:23 PM
Jdlrobson updated the task description. (Show Details)

Change 867305 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Echo icon should reflect seen status

https://gerrit.wikimedia.org/r/867305

matmarex renamed this task from Notification icon should not be read when there are seen notifications it should be gray to Notification icon should not be red when there are seen notifications it should be gray.Dec 14 2022, 3:44 AM
Jdlrobson renamed this task from Notification icon should not be red when there are seen notifications it should be gray to Notification icon should not be red when there all notifications have been seen.Dec 14 2022, 6:58 PM
Jdlrobson triaged this task as Low priority.
Jdlrobson updated the task description. (Show Details)

@ovasileva this was fixed this as part of wishathon so I've added it to our QA column.

Jdlrobson renamed this task from Notification icon should not be red when there all notifications have been seen to [Unplanned] Notification icon should not be red when there all notifications have been seen.Dec 14 2022, 11:47 PM

Thank you for continuing to work on this. ^_^

Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Login to any Wikimedia wiki from a mobile device
Produce a notification from another wiki (by editing the talk page from another account or any convenient way).
Go to any page from the mobile device and you will see that the notification icon has turned red. Now click on the red notification icon.
Go back and reload the page or go to a random page.
What happens?:
✅ AC1: After reload it should not be a red circle

Screen Recording 2023-01-06 at 4.21.12 PM.mov.gif (816×398 px, 213 KB)

The number of read-but-marked-unread messages now only appears very briefly when the page is refreshed, but I can live with that. Thank you. :-)