Page MenuHomePhabricator
Create Task
Maniphest T310376

Make VE Action API use Parsoid directly
Closed, ResolvedPublic
Actions

Description

Currently, ApiPArsoidTrait implements Parsoid transformations by calling RESTbase endpoints. Once the equivalent classes in core support all features that the endpoints in RESTbase support (e.g. stashing), ApiPArsoidTrait should be changed to use the Parsoid functionality present in core directly, rather than calling RESTbase.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Introduce HtmlInputTransformHelpermediawiki/coremaster+1 K -182
Experiment: Factor REST queries out of the API endpoints.mediawiki/extensions/VisualEditormaster+386 -228
Introduce HTMLTransformFactorymediawiki/coremaster+134 -4
WIP: HTMLTransformInput: introduce setOriginalPageBundlemediawiki/coremaster+214 -224
Rest: Refactor the `ParsoidHandler::html2wt()` methodmediawiki/coremaster+372 -122
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 In ProgressNoneT374135 Migrate RESTbase page content endpoints
 StalledNoneT324931 Clean up open RESTBase related tickets
 OpenNoneT262315 <CORE TECHNOLOGY> API Migration & RESTBase Sunset
 ResolvedMSantosT264669 Move VE API from RESTBase into core.
 ResolvedJgiannelosT344944 Move Parsoid endpoints out of RESTBase
 ResolvedJgiannelosT344945 Disable storage of Parsoid content in RESTbase
 ResolveddanielT329366 Enable WarmParsoidParserCache on all wikis
 ResolvedClement_GoubertT333528 Increase memory_limit for jobrunners to $wmgMemoryLimitParsoid
 DeclinedNoneT344946 Create a mechanism for purging output from (parsoid) HTML endpoints from edge caches (without RESTbase)
 ResolvedhnowlanT357504 Prepare amount of workers to handle enwiki traffic for parsoid endpoints
 ResolvedMSantosT328559 Replace usage of RESTbase parsoid endpoints
 ResolveddanielT320529 Configure VE backend to use Parsoid directly, instead of calling RESTbase
 ResolvedNoneT310376 Make VE Action API use Parsoid directly
 ResolvedNoneT310377 Make parsoid transformation API available internally
 ResolvedmatmarexT314565 ApiVisualEditor: Convert ApiParsoidTrait into a helper object.
 ResolvedPRODUCTION ERRORdanielT320703 VisualEditor can't save pages on de.wikipedia.beta
 ResolveddanielT320704 When VisualEditor saves an edit, it should use the same backend that the HTML was originally loaded from
 OpenMSantosT334238 Create deprecation plan for public parsoid endpoints
 ResolvedMSantosT335511 Talk to Google about transitioning REST-API-Crawler-Google from RESTBase endpoints
 ResolvedMSantosT335512 Transition Enterprise MediaWiki from RESTBase to core page HTML endpoints
 ResolvedROdonnell-WMFT353286 Test structured-contents parsing with the new WMF update in T335512
 ResolvedBUG REPORTMSantosT353689 REST HTML endpoint returning 500 for JSON page
 ResolvedBUG REPORTdanielT353688 REST: Trying to load the content "magic" image description pages leads to redirect loop
 ResolvedBUG REPORTdanielT353687 REST: page content endpoints fail on page "0"
 OpenBUG REPORTNoneT362187 REST HTML endpoint returning 500 for the first 3 - 5 calls for several pages
 InvalidNoneT335513 Selective outage of `/wikitext/to/lint` and `/html/to/wikitext` RESTBase endpoints
 ResolveddanielT350661 Expose parsoid transformation API from MediaWiki core.
 ResolvedBPirkleT370430 REST: define the content.v1 module that will replace Parsoid endpoints.
 In ProgressdanielT366835 REST: API modularization and versioning (tracking)
 DuplicateNoneT366838 Allow extensions to define REST modules
 StalleddanielT364400 map the /api/ prefix to /w/rest.php
 ResolveddanielT365754 REST: Allow extensions to define REST modules
 ResolveddanielT366837 REST: Introduce module definition files
 ResolveddanielT362480 Introduces support for modules into the REST API framework
 ResolveddanielT365753 REST: expose a machine readable directory of available API modules
 ResolveddanielT365755 REST: make module definition files compatible with OpenAPI specs
 OpendanielT365752 REST: Introduce support for private modules
 OpenNoneT366567 REST: introduce audience designations (proposal)
 ResolveddanielT359964 Move page lint job outside of restbase request/response cycle to allow completely disabling cassandra writes
 ResolveddanielT361013 Update lint tables independently of changeprop/restbase
 ResolveddanielT361413 Parsoid should perhaps use LinkUpdate job for lints instead of special Linter API/Hook
 DeclinedNoneT361411 Parsoid lints should be added to ParserOutput
 OpenNoneT367416 Route requests to parsoid endpoints to MediaWiki directly instead of RESTbase
 ResolvedJgiannelosT367418 ChangeProp: stop making no-cache requests to parsoid endpoints in RESTBase
 ResolvedBPirkleT365630 Remove long term caching and active purging for Parsoid endpoints in RESTBase
 ResolvedJgiannelosT367417 Enable LinterParseOnDerivedDataUpdate in production
 OpenNoneT373716 Reroute RESTbase Parsoid endpoints to core's REST endpoints
 ResolvedakosiarisT374683 Switchover plan from RESTbase to REST Gateway for rest_v1/page/html and rest_v1/page/title endpoints
 ResolvedNoneT374136 Route /api/rest_v1/page/title endpoints to MediaWiki core
 ResolvedaaronT384216 Reroute RESTBase /page/lint/ endpoints to MediaWiki REST endpoints
 ResolvedaaronT385066 Expose transform/wikitext/to/lint endpoints in production and reroute /rest_v1/ requests to them
 ResolvedaaronT388401 Enable transform/wikitext/to/lint endpoint in production
 ResolvedaaronT388412 Include wikitext/to/lint endpoint in OpenAPI spec generation
 OpenNoneT388420 Update MediaWiki REST API Documentation to include /wikitext/to/lint
 DuplicateNoneT391277 Draft: Reroute RESTbase Endpoints for Parsoid Data to MediaWiki REST Endpoints
 ResolvedNoneT396856 Reroute /v1/transform endpoints to rest gateway

Event Timeline

daniel created this task.Jun 10 2022, 4:23 PM
daniel moved this task from Unsorted pile to VE Backend pile on the Platform Team Workboards (MW Expedition) board.Jun 10 2022, 4:26 PM
Esanders updated the task description. (Show Details)Jun 10 2022, 4:27 PM
daniel triaged this task as Medium priority.Jun 29 2022, 10:31 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 30 2022, 3:38 PM
gerritbot added a comment.Jul 18 2022, 10:13 AM

Change 814739 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] Rest: Refactoring the `html2wt()` method

https://gerrit.wikimedia.org/r/814739

gerritbot added a project: Patch-For-Review.Jul 18 2022, 10:13 AM
gerritbot added a comment.Jul 22 2022, 9:50 AM

Change 814739 merged by jenkins-bot:

[mediawiki/core@master] Rest: Refactor the `ParsoidHandler::html2wt()` method

https://gerrit.wikimedia.org/r/814739

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Jul 22 2022, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 22 2022, 10:30 AM
gerritbot added a comment.Jul 26 2022, 8:25 AM

Change 817196 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/extensions/VisualEditor@master] Experiment: Factor REST queries out of the API endpoints.

https://gerrit.wikimedia.org/r/817196

gerritbot added a project: Patch-For-Review.Jul 26 2022, 8:25 AM
daniel raised the priority of this task from Medium to High.Jul 27 2022, 10:24 AM
gerritbot added a comment.Jul 29 2022, 8:57 PM

Change 818480 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] HTMLTransform: introduce setOriginalPageBundle

https://gerrit.wikimedia.org/r/818480

gerritbot added a comment.Aug 4 2022, 12:02 PM

Change 818480 abandoned by Daniel Kinzler:

[mediawiki/core@master] WIP: HTMLTransformInput: introduce setOriginalPageBundle

Reason:

Going for If97a74ce251f281b7d980928a01b764d6ec0d0a4

https://gerrit.wikimedia.org/r/818480

Nikki unsubscribed.Aug 5 2022, 7:55 AM
gerritbot added a comment.Aug 26 2022, 10:29 AM

Change 826813 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Introduce HTMLTRansformFactory

https://gerrit.wikimedia.org/r/826813

matmarex closed subtask T314565: ApiVisualEditor: Convert ApiParsoidTrait into a helper object. as Resolved.Aug 26 2022, 7:00 PM
gerritbot added a comment.Aug 30 2022, 7:46 PM

Change 826813 merged by jenkins-bot:

[mediawiki/core@master] Introduce HTMLTransformFactory

https://gerrit.wikimedia.org/r/826813

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.28; 2022-09-05); removed MW-1.39-notes (1.39.0-wmf.22; 2022-07-25).Aug 30 2022, 8:00 PM
gerritbot added a comment.Sep 1 2022, 9:30 AM

Change 817196 abandoned by Daniel Kinzler:

[mediawiki/extensions/VisualEditor@master] Experiment: Factor REST queries out of the API endpoints.

Reason:

obsolete

https://gerrit.wikimedia.org/r/817196

Maintenance_bot removed a project: Patch-For-Review.Sep 1 2022, 10:30 AM
Eevans unsubscribed.Sep 1 2022, 3:35 PM
PatchDemoBot added a comment.Sep 2 2022, 8:30 PM

Test wiki created on Patch demo by DAlangi (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7e16591eb7/wiki/Main Page

daniel moved this task from VE Backend pile to Doing on the Platform Team Workboards (MW Expedition) board.Sep 5 2022, 9:23 AM
daniel closed subtask T310377: Make parsoid transformation API available internally as Resolved.Sep 5 2022, 9:34 AM
gerritbot added a comment.Sep 9 2022, 2:45 PM

Change 828076 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Introduce HTMLTRansformHelper

https://gerrit.wikimedia.org/r/828076

gerritbot added a project: Patch-For-Review.Sep 9 2022, 2:45 PM
gerritbot added a comment.Sep 26 2022, 2:16 PM

Change 828076 merged by jenkins-bot:

[mediawiki/core@master] Introduce HtmlInputTransformHelper

https://gerrit.wikimedia.org/r/828076

daniel added a parent task: T320529: Configure VE backend to use Parsoid directly, instead of calling RESTbase.Oct 11 2022, 3:48 PM
PatchDemoBot added a comment.Oct 12 2022, 2:44 PM

Test wiki on Patch demo by DAlangi (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/7e16591eb7/w/

daniel closed this task as Resolved.Oct 18 2022, 2:53 PM
daniel closed subtask T320703: VisualEditor can't save pages on de.wikipedia.beta as Resolved.Dec 6 2022, 1:34 PM
DAlangi_WMF mentioned this in T341131: Replace usage of VRS in non-WMF deployed extensions (case: VEForAll).Jul 10 2023, 1:59 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 10 2023, 2:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits