We use left: 8px to position a 20px wide icon in a 36px area, which sounds correct, but it's wrong because it doesn't account for the 1px border around the input. It should be left: 9px instead. This affects all TextInput start icons, including the one in TypeaheadSearch
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| styles, TextInput: Add border width to icon position offset values | design/codex | main | +10 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Duplicate | None | T299666 Add TypeaheadSearch component to Codex | |||
| Resolved | • Sarai-WMDE | T297025 Add TypeaheadSearch to Codex | |||
| Resolved | BUG REPORT | • DAbad | T310408 TextInput start icon is off center by 1px |
Event Timeline
Comment Actions
@Catrope I hope you don't mind, but I went ahead and opened a patch in Codex to resolve this there
Comment Actions
Change 806277 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):
[design/codex@main] styles, TextInput: Add border width to icon position offset values
Comment Actions
Change 806277 merged by jenkins-bot:
[design/codex@main] styles, TextInput: Add border width to icon position offset values
Comment Actions
0px in comparison:
{F35247917}
9px provides us with the aimed for 8px distance to the 1px border.
{F35247920}