Page MenuHomePhabricator

Remove duplicate unique index on thread.thread_root
Closed, ResolvedPublic

Description

The DDL for table thread contains a UNIQUE constraint on the column definition and a UNIQUE (thread_root), that results in a duplicate index called thread_root_2 (at least in my version 10.1.34-MariaDB)

One definition should be removed.

CREATE TABLE /*$wgDBprefix*/thread (
  thread_id int(8) unsigned NOT NULL PRIMARY KEY auto_increment,
  thread_root int(8) unsigned UNIQUE NOT NULL,
  thread_ancestor int(8) unsigned NOT NULL,
  thread_parent int(8) unsigned NULL,
  thread_summary_page int(8) unsigned NULL,
  thread_subject varchar(255) NULL,
  thread_author_id int unsigned NULL,
  thread_author_name varchar(255) NULL,

  thread_modified char(14) binary NOT NULL default '',
  thread_created char(14) binary NOT NULL default '',

  thread_editedness int(1) NOT NULL default 0,

  thread_article_namespace int NOT NULL,
  thread_article_title varchar(255) binary NOT NULL,
  thread_article_id int(8) unsigned NOT NULL,

  -- Special thread types (deleted/move trace/normal)
  thread_type int(4) unsigned NOT NULL default 0,

  -- Sort key
  thread_sortkey varchar(255) NOT NULL default '',

  -- Reply count, -1 means uninitialised.
  thread_replies int(8) DEFAULT -1,

  -- Signature
  thread_signature TINYBLOB NULL,

  UNIQUE (thread_root)
) /*$wgDBTableOptions*/;

Event Timeline

Umherirrender triaged this task as Low priority.

Change 804739 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LiquidThreads@master] schema: Remove duplicate unique index from thread.thread_root

https://gerrit.wikimedia.org/r/804739

Change 804739 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] schema: Remove duplicate unique index from thread.thread_root

https://gerrit.wikimedia.org/r/804739

The index also named thread_root_page in the past, renamed by mistake in f79af1ce4b35f3a3823925505b3869b4d25812af, needs another patch

See T312288#8062447

Change 812036 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/LiquidThreads@master] schema: Drop duplicate index thread_root_page

https://gerrit.wikimedia.org/r/812036

Change 812036 merged by jenkins-bot:

[mediawiki/extensions/LiquidThreads@master] schema: Drop duplicate index thread_root_page

https://gerrit.wikimedia.org/r/812036