Page MenuHomePhabricator
Create Task
Maniphest T310437

Standardise type for timestamp columns in FlaggedRevs extension
Closed, ResolvedPublic
Actions

Description

According to T42626 the timestamp should be adjust from varbinary(14) to binary(14) because there is no need to hold infinite.

Affected columns:
flaggedpages.fp_pending_since
flaggedpage_pending.fpp_pending_since
flaggedrevs.fr_rev_timestamp
flaggedrevs.fr_timestamp
flaggedrevs_statistics.frs_timestamp

On the following columns the default of empty string needs to be removed:
flaggedrevs.fr_rev_timestamp

On the following columns the default of infinity needs to be removed:
flaggedpage_config.fpc_expiry

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Standardise type for timestamp columnsUmherirrendermediawiki/extensions/FlaggedRevsmaster+44 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Jun 12 2022, 12:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2022, 12:38 PM
Umherirrender triaged this task as Low priority.Jun 12 2022, 12:38 PM
gerritbot added a comment.Jun 12 2022, 1:02 PM

Change 804753 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/FlaggedRevs@master] Standardise type for timestamp columns

https://gerrit.wikimedia.org/r/804753

gerritbot added a project: Patch-For-Review.Jun 12 2022, 1:02 PM
Umherirrender added a parent task: T268548: Convert FlaggedRevs to AbstractSchema.Jun 12 2022, 8:59 PM
Zabe moved this task from Unsorted to Change on the Schema-change board.Jul 5 2022, 10:14 PM
gerritbot added a comment.Jul 13 2022, 6:56 PM

Change 804753 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Standardise type for timestamp columns

https://gerrit.wikimedia.org/r/804753

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 13 2022, 7:00 PM
Jdforrester-WMF closed this task as Resolved.Jul 13 2022, 7:03 PM
Umherirrender mentioned this in T312984: Adjust the field type of flaggedpages.fp_pending_since to fixed binary on wmf wikis.Jul 13 2022, 7:13 PM
Umherirrender mentioned this in T312985: Adjust the field type of flaggedpage_pending.fpp_pending_since to fixed binary on wmf wikis.
Umherirrender mentioned this in T312986: Adjust the field type of flaggedrevs_statistics.frs_timestamp to fixed binary on wmf wikis.
Umherirrender mentioned this in T312988: Drop default of flaggedpage_config.fpc_expiry on wmf wikis.
Umherirrender mentioned this in T312989: Adjust the field type of flaggedrevs.fr_rev_timestamp/fr_timestamp to fixed binary and drop default on wmf wikis.
Maintenance_bot removed a project: Patch-For-Review.Jul 13 2022, 7:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits