Completion checklist:
- Migrate all tests in function-orchestrator
- Deprecate function-schemata/utils.js:convertZListToArray method (or modify it to convert these lists to benjamin arrays instead
- Edit: These method was being used with the assumption that it returned both: 1) the canonical expression of a list, and 2) an iterable where every element is a list item. With the change to benjamin arrays, the canonical form is no longer an iterable of items of the same type, but the first element corresponds to the description of the list. For this reason, this method has been converted into two, which are being used for different things:
- convertZListToItemsArray: for returning an iterable list with only the items of the typed list.
- convertZListToBenjaminArray: for canonicalization process.
- This method had a benjamin=true flag before that divided the logic and could have both outcomes. However, I (gengh) have transformed it into two methods just to add readability, clarity and an extra security measure, and make sure that the developer intentionally chooses the used method depending on what they want it for.
- Edit: These method was being used with the assumption that it returned both: 1) the canonical expression of a list, and 2) an iterable where every element is a list item. With the change to benjamin arrays, the canonical form is no longer an iterable of items of the same type, but the first element corresponds to the description of the list. For this reason, this method has been converted into two, which are being used for different things:
- Remove benjamin feature flags from normalize and canonicalize in function-schemata