Maniphest T310500

Improve test coverage of HookHandler/PreferencesHandler.php
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Tchanders
	Jun 13 2022, 2:43 PM

Tags

Referenced Files

None

Subscribers

Description

HookHandler/PreferencesHandler.php
onGetPreferences, checkAllIPInfoAgreements, logEvent, onSaveUserOptions

Details

	Subject	Repo	Branch	Lines +/-
	Improve test coverage of HookHandler/PreferencesHandler	mediawiki/extensions/IPInfo	master	+122 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		kostajh	T309580 Improve IPInfo test coverage
		Resolved		• TThoabala	T310500 Improve test coverage of HookHandler/PreferencesHandler.php

Event Timeline

Tchanders created this task.Jun 13 2022, 2:43 PM

Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Jun 13 2022, 2:52 PM

• AGueyte set the point value for this task to 3.Jun 27 2022, 5:42 PM

ARamirez_WMF moved this task from Triage/To be Estimated to AHaT Sprint 11: The Fascinator on the Anti-Harassment board.Jun 28 2022, 5:33 PM

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 11: The Fascinator); removed Anti-Harassment.

• TThoabala claimed this task.Jul 1 2022, 9:48 AM

• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.

Change 811586 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Improve test coverage of HookHandler/PreferencesHandler

https://gerrit.wikimedia.org/r/811586

gerritbot added a project: Patch-For-Review.Jul 6 2022, 7:54 AM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Jul 7 2022, 8:26 AM

Tchanders moved this task from Code Review 🔍 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Jul 8 2022, 1:29 PM

Change 811586 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Improve test coverage of HookHandler/PreferencesHandler

https://gerrit.wikimedia.org/r/811586

Maintenance_bot removed a project: Patch-For-Review.Jul 8 2022, 2:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 5:02 AM

• Prtksxna closed this task as Resolved.Aug 8 2022, 4:14 AM

• Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM