Page MenuHomePhabricator
Create Task
Maniphest T310503

Improve test coverage of InfoRetriever/ContributionInfoRetriever.php and InfoRetriever/BlockInfoRetriever.php
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Coverage report: https://doc.wikimedia.org/cover-extensions/IPInfo/InfoRetriever/index.html

  • InfoRetriever/BlockInfoRetriever.php
  • __construct, getName, retrieveFromIP
  • InfoRetriever/ContributionInfoRetriever.php
  • __construct, getName, retrieveFromIP

Details

SubjectRepoBranchLines +/-
Update coverage docs for BlockInfoRetrieverTest, ContributionInfoRetrieverTestmediawiki/extensions/IPInfomaster+4 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders renamed this task from Improve coverage of InfoRetriever/ContributionInfoRetriever.php and InfoRetriever/BlockInfoRetriever.php to Improve test coverage of InfoRetriever/ContributionInfoRetriever.php and InfoRetriever/BlockInfoRetriever.php.Jun 13 2022, 2:46 PM
Tchanders created this task.
Tchanders moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Jun 13 2022, 2:52 PM
• AGueyte set the point value for this task to 3.Jun 13 2022, 3:43 PM
Tchanders updated the task description. (Show Details)Jun 13 2022, 3:43 PM
Tchanders moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Jun 14 2022, 3:37 PM
ARamirez_WMF moved this task from Cards ready for development to AHaT Sprint 10: The Mokorotlo on the Anti-Harassment board.Jun 14 2022, 5:04 PM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 10: The Mokorotlo); removed Anti-Harassment.
STran claimed this task.Jun 21 2022, 7:43 AM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.
gerritbot added a comment.Jun 21 2022, 7:50 AM

Change 807055 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Update coverage docs for BlockInfoRetrieverTest, ContributionInfoRetrieverTest

https://gerrit.wikimedia.org/r/807055

gerritbot added a project: Patch-For-Review.Jun 21 2022, 7:50 AM
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 21 2022, 7:58 AM
Tchanders moved this task from Code Review 🔍 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 21 2022, 5:17 PM
gerritbot added a comment.Jun 21 2022, 5:19 PM

Change 807055 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Update coverage docs for BlockInfoRetrieverTest, ContributionInfoRetrieverTest

https://gerrit.wikimedia.org/r/807055

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2022, 5:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 21 2022, 6:00 PM
• Niharika closed this task as Resolved.Jul 26 2022, 2:12 PM
• Prtksxna moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 4:07 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL