Page MenuHomePhabricator
Create Task
Maniphest T310522

On Minerva desktop clicking the notification icon has no effect
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
Next to the user menu there is a red circle showing the number of unread alerts/notifications. Clicking this does not produce any effect.

What should have happened instead?:
Clicking the red circle should open the notifications menu.

As noted in T306737 this does work when viewing it on the mobile domain (en.m.wikipedia.org). Based on this I'm guessing this is caused by the lack of modal menu's when Mobile Frontend is not loaded as noted in T307848#7915177 by @Jdlrobson

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Echomaster+7 -5Enable Echo on Minerva rather than mobile domain
Customize query in gerrit

Related Objects

Event Timeline

Asartea created this task.Jun 13 2022, 4:31 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 13 2022, 4:31 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
kostajh added a subscriber: kostajh.Jun 13 2022, 4:38 PM

Perhaps related: T310358: [Unplanned] Notification icon should not be red when there all notifications have been seen

kostajh added a project: Web-Team-Backlog.Jun 13 2022, 4:39 PM
In T310522#7999535, @kostajh wrote:

Perhaps related: T310358: [Unplanned] Notification icon should not be red when there all notifications have been seen

Er, no, that seems like a separate breakage for that counter. :\

Jdlrobson added a comment.Jun 13 2022, 4:52 PM

Er, no, that seems like a separate breakage for that counter. :\

I'll take a look today. I have an idea of how to fix this one.

Jdlrobson renamed this task from On Minerva desktop the notifications menu is completely broken to On Minerva desktop clicking the notification icon has no effect.Jun 13 2022, 4:53 PM
Jdlrobson claimed this task.
gerritbot added a comment.Jun 13 2022, 6:26 PM

Change 805220 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Enable Echo on Minerva rather than mobile domain

https://gerrit.wikimedia.org/r/805220

gerritbot added a project: Patch-For-Review.Jun 13 2022, 6:26 PM
Jdlrobson added a comment.Jun 13 2022, 6:27 PM

Echo is also broken on Vector mobile (https://en.m.wikipedia.org/wiki/User:Jdlrobson?useskin=vector).

The issue here is the use of wgMFMode rather than checking the skin is Minerva. wgMFMode is present on any skin in the mobile domain, but the "mobile" code only actually works on Minerva.

The above patch rewires this to work based on skin. The wgMFMode check is additional.

TheresNoTime added a subscriber: TheresNoTime.Jun 13 2022, 6:47 PM

I note your self -2, but just FYI 805220 does not seem to resolve this — tested on patchdemo (excuse my animated attempts....)

firefox_TxIPUw8slF.gif (360×1 px, 109 KB)

Jdlrobson added a comment.Jun 13 2022, 9:35 PM

I note your self -2, but just FYI 805220 does not seem to resolve this — tested on patchdemo (excuse my animated attempts....)

Yeh that should be fixed in the latest patch. Sorry for the confusion.

ovasileva triaged this task as Medium priority.Jun 14 2022, 3:32 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.
Jdlrobson reassigned this task from Jdlrobson to kostajh.Jun 14 2022, 10:03 PM
Jdlrobson moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/805220/3. Needs review from Growth team.

kostajh edited projects, added Growth-Team (Current Sprint); removed Growth-Team.Jun 15 2022, 9:11 AM
kostajh moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Jdlrobson lowered the priority of this task from Medium to Low.Jun 16 2022, 5:17 PM
Jdlrobson moved this task from Blocked on Others to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jun 21 2022, 5:25 PM
gerritbot added a comment.Jun 21 2022, 6:54 PM

Change 805220 abandoned by Jdlrobson:

[mediawiki/extensions/Echo@master] Enable Echo on Minerva rather than mobile domain

Reason:

No longer needed

https://gerrit.wikimedia.org/r/805220

Jdlrobson closed this task as Resolved.Jun 21 2022, 6:56 PM

@kostajh pointed out the issue is fixed in production now.
Note there is another issue with Vector as mobile skin always using JavaScript fallback (https://en.m.wikipedia.org/wiki/Main_Page?useskin=vector) but that has never worked and is part of the goals of T257143.

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2022, 7:30 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL