Page MenuHomePhabricator

On Minerva desktop clicking the notification icon has no effect
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
Next to the user menu there is a red circle showing the number of unread alerts/notifications. Clicking this does not produce any effect.

What should have happened instead?:
Clicking the red circle should open the notifications menu.

As noted in T306737 this does work when viewing it on the mobile domain (en.m.wikipedia.org). Based on this I'm guessing this is caused by the lack of modal menu's when Mobile Frontend is not loaded as noted in T307848#7915177 by @Jdlrobson

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

Er, no, that seems like a separate breakage for that counter. :\

I'll take a look today. I have an idea of how to fix this one.

Jdlrobson renamed this task from On Minerva desktop the notifications menu is completely broken to On Minerva desktop clicking the notification icon has no effect.Mon, Jun 13, 4:53 PM
Jdlrobson claimed this task.

Change 805220 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Enable Echo on Minerva rather than mobile domain

https://gerrit.wikimedia.org/r/805220

Echo is also broken on Vector mobile (https://en.m.wikipedia.org/wiki/User:Jdlrobson?useskin=vector).

The issue here is the use of wgMFMode rather than checking the skin is Minerva. wgMFMode is present on any skin in the mobile domain, but the "mobile" code only actually works on Minerva.

The above patch rewires this to work based on skin. The wgMFMode check is additional.

I note your self -2, but just FYI 805220 does not seem to resolve this — tested on patchdemo (excuse my animated attempts....)

firefox_TxIPUw8slF.gif (360×1 px, 109 KB)

I note your self -2, but just FYI 805220 does not seem to resolve this — tested on patchdemo (excuse my animated attempts....)

Yeh that should be fixed in the latest patch. Sorry for the confusion.

Jdlrobson lowered the priority of this task from Medium to Low.Thu, Jun 16, 5:17 PM

Change 805220 abandoned by Jdlrobson:

[mediawiki/extensions/Echo@master] Enable Echo on Minerva rather than mobile domain

Reason:

No longer needed

https://gerrit.wikimedia.org/r/805220

@kostajh pointed out the issue is fixed in production now.
Note there is another issue with Vector as mobile skin always using JavaScript fallback (https://en.m.wikipedia.org/wiki/Main_Page?useskin=vector) but that has never worked and is part of the goals of T257143.