VE has some JS that triggers rewriting the tabs in some situations, but this is seemingly triggering incorrectly in vector-2022 (working in vector classic).
Expected:
Observed:
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix tab messages being changed wrong by JavaScript | mediawiki/extensions/VisualEditor | master | +7 -10 |
Related Objects
Related Objects
Event Timeline
Comment Actions
It's the result of changes from T301203. There was a whole mess with renaming localisation messages, but the end result is that when the skin doesn't define an override (and Vector 2022 doesn't), we should use the message 'skin-view-edit' instead of 'edit'.
Both messages read "Edit" by default, but the latter is overridden on English Wikipedia to "Edit this page" (to change the label for MonoBook), so the issue wasn't apparent when testing locally.
Comment Actions
Change 805218 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Fix tab messages being changed wrong by JavaScript
Comment Actions
Change 805218 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix tab messages being changed wrong by JavaScript