Page MenuHomePhabricator

$wgEnotifUserTalk forced showing option 'minor edits notification' in Preferences
Closed, ResolvedPublic


Author: danny.leinad


'wgEnotifUserTalk' => array(

'default' => true,

'wgEnotifMinorEdits' => array(

'default' => false,

in this^ configuration in Special:Preferences is shown option "E-mail me also for minor edits of pages" - but if I understand correctly this configuration, this option shouldn't be shown (is useless).

Make a note that $wgEnotifMinorEdits does not affect the user's own talk page (they will be notified about all changes, regardless of this setting) - from$wgEnotifMinorEdits.

Version: 1.20.x
Severity: normal
See Also:



Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:37 PM
bzimport set Reference to bz29055.
bzimport added a subscriber: Unknown Object (MLST).

danny.leinad wrote:

PS This applies only to projects with $wgEnotifWatchlist = false;

This was fixed already in r83365 (not live - part of 1.18 currently). If its really super important you might be able to convince someone to merge the change in early.

Also, I don't understand what this has to do with $wgEnotifWatchlist or why it is tagged shell.

Anyways, closing WFM (is that right resolution? it works for me on trunk, but its obviously not fixed on 'pedia, so I don't really know)

danny.leinad wrote:

I thought there is problem with some hidden configuration.

Now I checked code from trunk... with configuration:


$wgEnotifUserTalk = true;

$wgEnotifMinorEdits = true;
$wgEnotifWatchlist = false;

and still I see option "E-mail me also for minor edits of pages" - this option I useless in this configuration, because as I wrote "$wgEnotifMinorEdits does not affect the user's own talk page" ($wgEnotifMinorEdits).

danny.leinad wrote:

If I understand correctly, r83365 needs a little improvement:

Doesn't make sense to have if disabled.

if ( !$wgEnotifWatchlist ) {

$wgHiddenPrefs[] = 'enotifminoredits';


I think it'd make more sense to just fix the bug and make the preference work.

(Note $wgEnotifMinorEdits does have an affect on if user talk page notifications, the preference does not atm.)

I made the don't send on minor edits preference apply to both talk page edits, and watchlist edits in r88441.

Please feel free to re-open if its really a bad idea to do that, and just hiding it would be better.

I wonder whether it still makes sense to have the permission "Not have minor edits to discussion pages trigger the new messages prompt (nominornewtalk)" (used for bots), now that users can avoid all of them with this preference.
In general, I'm not sure it's consistent with the whole email notification system (while hiding was enough to fix the bug).