Page MenuHomePhabricator
Create Task
Maniphest T310559

Minerva initial notification count does not include messages
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Generate notifications e.g. php extensions/Echo/maintenance/generateSampleNotifications.php --user Admin --agent Jdlrobson --other Jdlrobson making sure you have both alerts AND notices
  • Load any page in Minerva as a logged in user
  • Click the notification icon
  • Close the overlay

What happens?:
The initially displayed count is not the same as the post-overlay count. This is because the initial count is only the number of alerts NOT the number of messages

What should have happened instead?:

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Details

SubjectRepoBranchLines +/-
Display correct numbers on the combined notification badgemediawiki/skins/MinervaNeuemaster+33 -9
Add badge that combines notices and alertsmediawiki/extensions/Echomaster+77 -55
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 13 2022, 11:14 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 13 2022, 11:14 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Jdlrobson claimed this task.Jun 13 2022, 11:15 PM
Jdlrobson mentioned this in T310358: [Unplanned] Notification icon should not be red when there all notifications have been seen.
Jdlrobson mentioned this in T310537: [Regression] Minerva notification count is not localized to current language.Jun 13 2022, 11:18 PM
gerritbot added a comment.Jun 14 2022, 9:53 PM

Change 805485 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Add badge that combines notices and alerts

https://gerrit.wikimedia.org/r/805485

gerritbot added a project: Patch-For-Review.Jun 14 2022, 9:53 PM
PatchDemoBot added a comment.Jun 16 2022, 8:27 PM

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/9225eb4c81/w/

PatchDemoBot added a comment.Jun 16 2022, 8:40 PM

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/9225eb4c81/w/

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jun 17 2022, 7:27 PM
• mewoph moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Jun 21 2022, 6:58 PM
Jdlrobson moved this task from Backlog to Address Echo painpoints on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Jun 22 2022, 12:00 AM
Jdlrobson merged a task: T312793: Echo/Minerva: The notification icon does not turn red when the notice is generated.Jul 14 2022, 5:25 PM
Jdlrobson added a subscriber: Yahya.
Jdlrobson mentioned this in T313609: Can't click notifications in Minerva desktop.Jul 27 2022, 8:09 AM
MShilova_WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).Sep 2 2022, 11:49 AM
MShilova_WMF moved this task from Inbox to Triaged on the Growth-Team board.
gerritbot added a comment.Sep 16 2022, 6:25 PM

Change 805485 abandoned by Jdlrobson:

[mediawiki/extensions/Echo@master] Add badge that combines notices and alerts

Reason:

Focusing on Vector 2022 for now.

https://gerrit.wikimedia.org/r/805485

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2022, 6:30 PM
Jdlrobson removed a project: Web-Team-Backlog (Needs Prioritization (Tech)).Sep 23 2022, 9:01 PM
ppelberg subscribed.Dec 7 2022, 5:52 PM
gerritbot added a comment.Dec 12 2022, 11:00 PM

Change 867290 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Display correct numbers on the combined notification badge

https://gerrit.wikimedia.org/r/867290

gerritbot added a project: Patch-For-Review.Dec 12 2022, 11:00 PM
matmarex subscribed.Dec 12 2022, 11:01 PM
gerritbot added a comment.Dec 13 2022, 2:03 AM

Change 867290 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Display correct numbers on the combined notification badge

https://gerrit.wikimedia.org/r/867290

Maintenance_bot removed a project: Patch-For-Review.Dec 13 2022, 2:30 AM
Jdlrobson added a comment.Dec 13 2022, 6:17 PM

@matmarex is anyone QAing this one on your side?

matmarex added a comment.Dec 13 2022, 7:50 PM

Sure, I'll ask the folks to take a look. I think this is the same issue as T324690 that we discovered.

matmarex added a project: Editing-team (Kanban Board).Dec 13 2022, 7:50 PM
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
Jdlrobson awarded a token.Dec 13 2022, 11:41 PM
EAkinloose added subscribers: Ryasmeen, EAkinloose.Jan 11 2023, 2:49 PM
In T310559#8464520, @matmarex wrote:

Sure, I'll ask the folks to take a look. I think this is the same issue as T324690 that we discovered.

This works fine now. Looked into it fine while testing T324690.
However, @Ryasmeen caught a new 🐜 : The notification icon changes color to grey after closing the overlay. See

IMG_2045.jpg (2×1 px, 614 KB)
.

EAkinloose moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Jan 11 2023, 2:50 PM
Jdlrobson added a comment.Jan 11 2023, 4:55 PM
In T310559#8516606, @EAkinloose wrote:
In T310559#8464520, @matmarex wrote:

Sure, I'll ask the folks to take a look. I think this is the same issue as T324690 that we discovered.

This works fine now. Looked into it fine while testing T324690.
However, @Ryasmeen caught a new 🐜 : The notification icon changes color to grey after closing the overlay. See

IMG_2045.jpg (2×1 px, 614 KB)
.

That behavior is intentional and was that way prior to the bug I introduced. (the purpose is to indicate the notification have been marked as a read). I do think the design looks off though, and this feature could do with a design refresh/rethink.

matmarex moved this task from Blocked / Needs More Work to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 12 2023, 12:55 AM
EAkinloose edited projects, added Verified; removed Editing QA.Jan 12 2023, 6:11 PM
ppelberg closed this task as Resolved.Jan 21 2023, 12:33 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 21 2023, 12:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits