Page MenuHomePhabricator

Define priorityClassName for istio and cert-manager deployments
Closed, ResolvedPublic

Description

Starting from k8s 1.17 critical pods can now be created in namespaces other than kube-system. To limit critical pods to the kube-system namespace, cluster admins should create an admission configuration file limiting critical pods by default, and a matching quota object in the kube-system namespace permitting critical pods in that namespace. See https://kubernetes.io/docs/concepts/policy/resource-quotas/#limit-priority-class-consumption-by-default for details. (#76310)

This should have been possible already with 1.16 and we're prepared to just switch it on in:

  • custom_deploy.d/istio/main/config.yaml
  • custom_deploy.d/istio/ml-serve/config.yaml
  • charts/cert-manager/values.yaml

It would probably make sense to add support into the cfss-issuer chart as well and set the same class as for cert-manager

Event Timeline

Change 878190 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] Add istio config for main/wikikube clusters on k8s 1.23

https://gerrit.wikimedia.org/r/878190

Change 878190 merged by jenkins-bot:

[operations/deployment-charts@master] Add istio config for main/wikikube clusters on k8s 1.23

https://gerrit.wikimedia.org/r/878190

Change 895169 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] cert-manager: Set priorityClassName by default

https://gerrit.wikimedia.org/r/895169

Change 895170 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] admin_ng: Remove warning comment about allowCriticalPods

https://gerrit.wikimedia.org/r/895170

Change 895171 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] custom_deploy: Set priorityClass for istio in ml and dse

https://gerrit.wikimedia.org/r/895171

Change 895169 merged by jenkins-bot:

[operations/deployment-charts@master] cert-manager: Set priorityClassName by default

https://gerrit.wikimedia.org/r/895169

Change 895170 merged by jenkins-bot:

[operations/deployment-charts@master] admin_ng: Remove warning comment about allowCriticalPods

https://gerrit.wikimedia.org/r/895170

Change 895171 merged by jenkins-bot:

[operations/deployment-charts@master] custom_deploy: Set priorityClass for istio in ml and dse

https://gerrit.wikimedia.org/r/895171

Change 895179 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] cfssl-issuer: Set priorityClassName system-cluster-critical

https://gerrit.wikimedia.org/r/895179

Change 895179 merged by jenkins-bot:

[operations/deployment-charts@master] cfssl-issuer: Set priorityClassName system-cluster-critical

https://gerrit.wikimedia.org/r/895179