Page MenuHomePhabricator

Impact module: "Edit again" Call To Action
Closed, DeclinedPublic

Description

On the Impact module, for displayed previously edited articles: add an “Edit again” call to action (CTA) on articles which have other Suggested editing tasks.

Show a specific CTA for a task if there is another type of edit action required (e.g., “Add references” after doing a “Copyedit”)
If more than one task type or other maintenance template is on the task, add a general CTA to “Edit again”

Screen Shot 2022-06-14 at 2.20.45 PM.png (436×454 px, 65 KB)

Figma Design.


Acceptance Criteria

Given I'm viewing the newcomer homepage's impact module,
When I have edited an article, and it now appears in the impact module,
Then there is a call to action to edit again if there is another maintenance template on the article unrelated to the suggested edit I completed.

  • Only show a CTA if the article includes a template related to suggested edits (Copyedit, Add links between articles, Find references, Update articles, Expand short articles). NOT in scope: articles with an associated structured task.
  • If more than one template, CTA= Edit again
  • If Copyedit template, CTA= Copy edit
  • If Find reference, CTA= Add references
  • If Update articles, CTA= Update article
  • If Expand short article, CTA= Expand article

qqq translator instructions: This string will show to newcomers as a "call to action" to edit a specific article again.

Completion checklist

Functionality

  • The patches have been code reviewed and merged
  • The task passes its acceptance criteria

Engineering

  • There are existing and passing unit/integration tests
  • Tests for every involved patch should pass
  • Coverage for every involved project should have improved or stayed the same

Design & QA

  • If the task is UX/Design related: it must be reviewed and approved by the UX/Design team
  • Must be reviewed and approved by Quality Assurance.

Documentation

  • Related and updated documentation done where necessary

Event Timeline

@Trizek-WMF Yes, but I can see how this task might be confused with another related task we've discussed. I've updating the description slightly so hopefully that helps add clarification.
In the screenshot, see how there are small blue CTAs below the first two article titles?

In the screenshot, see how there are small blue CTAs below the first two article titles?

Ha, these are the CTAs? :o

Just looking at the screenshot, I thought that these links were the actions done by the user when they edited the article.

This is not straightforward - either we'd have to do a separate search with a page ID filter for each task type (somewhat ugly and slow), or we need to fetch task type data from Cirrus directly (T243478: Newcomer tasks: fetch ElasticSearch data for search results).

The task calls these calls to action, but what's the action? Clicking on the tiny text? Clicking on the table row? What should happen for articles with multiple task types?

Thanks for the info, @Tgr . I'll talk with design about this. It sounds like this might be a fair amount of work and user testing showed this "call to action" wasn't a very clear to many people, so I want to reconsider this task.

Closing this task based on current designs: T313271