Page MenuHomePhabricator

Mobile frontend cannot identify special page from nonexistent page
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
It prompts you to create a page

What should have happened instead?:
It should just go to the Special:Contributions and display the new user's contributors, even if there are none.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Event Timeline

Ammarpad added a subscriber: Ammarpad.

This was supposed to be fixed by T242195. It probably regressed.

Change 805779 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/skins/MinervaNeue@master] initMobile.js: Filter out all special pages in user redlink CTA

https://gerrit.wikimedia.org/r/805779

Per https://phabricator.wikimedia.org/T242195#5786788 the real issue here is these links should not be using this class. The red link is used for pages that don't exist. The contributions page does exist and shouldnt be red just because the user page link doesn't.

Per https://phabricator.wikimedia.org/T242195#5786788 the real issue here is these links should not be using this class. The red link is used for pages that don't exist. The contributions page does exist and shouldnt be red just because the user page link doesn't.

I saw that, but obviously who will fix that? It's clear that's entrenched and more difficult or risky to fix than this minor fix in the Minerva. I made the above patch because per your comment in T242195#7501131, you suggested to have fixed it (in the minerva, not core) and this ticket obviously shows that code stopped working or maybe never fixed the issue we are talking about.

Change 806237 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Contributions link should be marked up differently from non-existent pages

https://gerrit.wikimedia.org/r/806237

Why would this be more entrenched and difficult/risky to fix? I've posted a first patch that moves us in that direction.

Change 805779 abandoned by Ammarpad:

[mediawiki/skins/MinervaNeue@master] initMobile.js: Filter out all special pages in user redlink CTA

Reason:

https://gerrit.wikimedia.org/r/805779

Change 806237 merged by jenkins-bot:

[mediawiki/core@master] Contributions link should be marked up differently from non-existent pages

https://gerrit.wikimedia.org/r/806237

Jdlrobson claimed this task.