Page MenuHomePhabricator
Create Task
Maniphest T310693

Make Metrics Platform Clients record sampling rate and unit in the event
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Motivating examples:

TODO

  • Update the Metrics Event schema to include sampling unit and rate
  • Make the Metrics Platform Clients record the sampling unit and rate as part of the event that is submitted via ::dispatch()
    • Update the JS client library
    • Update the Java client library

Notes

The PHP client library doesn't need to be updated because it doesn't do sampling.

Details

SubjectRepoBranchLines +/-
Add product metrics fragments and schemasschemas/event/secondarymaster+2 K -0
Add analytics/product_metrics/{app,web}/base schemasschemas/event/secondarymaster+1 K -0
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
[JS][Java] Mix in sample unit and raterepos/data-engineering/metrics-platform!7phuedxwork/phuedx/T310693main
Customize query in GitLab

Related Objects
Search...

Event Timeline

phuedx created this task.Jun 15 2022, 12:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2022, 12:07 PM
phuedx added a project: Metrics Platform Backlog.Jun 15 2022, 12:07 PM
phuedx added a subscriber: • EChetty.
phuedx renamed this task from Make Metrics Platform Clients record sampling rate and unit as part of the event to Make Metrics Platform Clients record sampling rate and unit in the event.Jun 15 2022, 12:24 PM
phuedx updated the task description. (Show Details)
MNeisler subscribed.Jun 15 2022, 1:29 PM
MNeisler mentioned this in T309260: Make EditAttemptStep sampling rate consistent with MobileWebUIActions and DesktopWebUI.Jun 15 2022, 3:07 PM
Ottomata subscribed.Jun 29 2022, 1:16 PM
phuedx updated the task description. (Show Details)Jul 26 2022, 3:46 PM
phuedx mentioned this in T309013: EditAttemptStep Migration to (monoschema) MP.Jul 26 2022, 5:34 PM
phuedx moved this task from Backlog to To be discussed on the Metrics Platform Backlog board.Mar 16 2023, 1:24 PM
phuedx moved this task from To be discussed to To be prioritised on the Metrics Platform Backlog board.Apr 3 2023, 12:34 PM
phuedx moved this task from To be prioritised to Schema improvements on the Metrics Platform Backlog board.Jul 31 2023, 2:50 PM
phuedx moved this task from Schema improvements to Client improvements on the Metrics Platform Backlog board.Aug 15 2023, 2:32 PM
phuedx mentioned this in T343331: Audit existing schemas to identify Core Interactions.Aug 16 2023, 10:35 AM
phuedx added a project: Data Products.Sep 14 2023, 12:23 PM
phuedx moved this task from Incoming to Sprint 01 on the Data Products board.
phuedx edited projects, added Data Products (Sprint 01); removed Data Products.
VirginiaPoundstone set the point value for this task to 5.Sep 14 2023, 1:37 PM
phuedx moved this task from Sprint Backlog to In Process on the Data Products (Sprint 01) board.Sep 29 2023, 2:59 PM
CodeReviewBot added a comment.Oct 2 2023, 8:43 AM

phuedx updated https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/7

Draft: Mix in sample unit and rate

phuedx updated the task description. (Show Details)Oct 2 2023, 1:12 PM
phuedx added a comment.Oct 2 2023, 1:45 PM
  • Update the PHP Metrics Platform Client

The PHP client library can't sample by the available units and so wouldn't need to record sampling unit and rate as part of the event.

phuedx updated the task description. (Show Details)Oct 2 2023, 1:45 PM
phuedx claimed this task.Oct 2 2023, 3:43 PM
phuedx moved this task from Sprint 01 to Sprint 02 on the Data Products board.Oct 3 2023, 1:38 PM
phuedx edited projects, added Data Products (Sprint 02); removed Data Products (Sprint 01).
phuedx moved this task from Sprint Backlog to In Process on the Data Products (Sprint 02) board.
phuedx moved this task from In Process to Ready for Code Review on the Data Products (Sprint 02) board.Oct 11 2023, 8:25 AM
CodeReviewBot added a comment.Oct 11 2023, 8:27 AM

phuedx updated https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/7

[JS][Java] Mix in sample unit and rate

phuedx updated the task description. (Show Details)Oct 11 2023, 12:43 PM
cjming moved this task from Ready for Code Review to In code review / Tech Input on the Data Products (Sprint 02) board.Oct 16 2023, 3:44 PM
CodeReviewBot added a comment.Oct 16 2023, 5:57 PM

cjming merged https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/7

[JS][Java] Mix in sample unit and rate

cjming moved this task from In code review / Tech Input to Sign Off on the Data Products (Sprint 02) board.Oct 16 2023, 5:57 PM
gerritbot added a comment.Oct 18 2023, 8:51 AM

Change 952252 had a related patch set uploaded (by Phuedx; author: Phuedx):

[schemas/event/secondary@master] Add analytics/metrics_platform/{app,web}/base schemas

https://gerrit.wikimedia.org/r/952252

gerritbot added a project: Patch-For-Review.Oct 18 2023, 8:51 AM
phuedx updated the task description. (Show Details)Oct 18 2023, 8:53 AM
VirginiaPoundstone moved this task from Sign Off to Done on the Data Products (Sprint 02) board.Oct 25 2023, 4:07 PM
gerritbot added a comment.Nov 7 2023, 4:54 PM

Change 951191 had a related patch set uploaded (by Phuedx; author: Clare Ming):

[schemas/event/secondary@master] Add product metrics fragments and schemas

https://gerrit.wikimedia.org/r/951191

gerritbot added a comment.Nov 7 2023, 4:55 PM

Change 952252 abandoned by Phuedx:

[schemas/event/secondary@master] Add analytics/product_metrics/{app,web}/base schemas

Reason:

Superseded by the latest PS of I9dd03fc6bb4bca94a84c23d5b0d04f3bc0c20e6a

https://gerrit.wikimedia.org/r/952252

gerritbot added a comment.Nov 8 2023, 6:24 AM

Change 951191 merged by jenkins-bot:

[schemas/event/secondary@master] Add product metrics fragments and schemas

https://gerrit.wikimedia.org/r/951191

phuedx closed this task as Resolved.Nov 13 2023, 4:54 PM

Per T310693#9280856.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL