Change 805810 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Use surface's cancel command to close the editor

https://gerrit.wikimedia.org/r/805810

Change 805810 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use surface's cancel command to close the editor

https://gerrit.wikimedia.org/r/805810

This works fine. However @matmarex , I am curious about the expected result for pressing the esc key while in the source editor. Nothing happens currently.

I think that's expected, the mobile source editor never supported this and we didn't change it here, but I guess maybe we should change it as well?

I'm not sure if we want to work on this. The change for visual mode was motivated by some inconsistencies in the behavior of the Escape key on desktop, and it was easier to apply the same bahvior to mobile than to try to disable it, but there isn't really such motivation for the source mode.

In T310694#8007477, @matmarex wrote:

I think that's expected, the mobile source editor never supported this and we didn't change it here, but I guess maybe we should change it as well?

I'm not sure if we want to work on this. The change for visual mode was motivated by some inconsistencies in the behavior of the Escape key on desktop, and it was easier to apply the same bahvior to mobile than to try to disable it, but there isn't really such motivation for the source mode.

It's fine to leave it as is for now. I just wanted to confirm. Thanks!