Pressing Escape when the focus is outside of the editor (e.g. the sidebar language popup is open) closes VE
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Jun 15 2022, 12:54 PM

Description

Open VE
Open the language popup (skin:vector classic, click the cog):
Press escape to close the popup

Observe VE has closed as well

VE will close when escape is pressed anywhere on the page e.g. the site search bar, or any popups generated by other tools. We should only capture escape events from within VE itself.

Details

	Subject	Repo	Branch	Lines +/-
	Use surface's cancel command to close the editor	mediawiki/extensions/VisualEditor	master	+13 -46

Customize query in gerrit

Related Objects

Mentioned In: T311467: [wmf.17-mobile] "Suggestions" label has no padding
T306763: No timeout recovery when switching between visual and source editor

Event Timeline

Esanders created this task.Jun 15 2022, 12:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2022, 12:54 PM

Change 805810 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Use surface's cancel command to close the editor

https://gerrit.wikimedia.org/r/805810

gerritbot added a project: Patch-For-Review.Jun 15 2022, 12:55 PM

Change 805810 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use surface's cancel command to close the editor

https://gerrit.wikimedia.org/r/805810

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 15 2022, 8:17 PM

matmarex added a project: Editing-team (Kanban Board).

matmarex edited projects, added Editing QA; removed Patch-For-Review.

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

matmarex renamed this task from Pressing escape while the language popup is open closes VE to Pressing escape the focus is outside of the editor (e.g. the sidebar language popup is open) closes VE.Jun 15 2022, 8:19 PM

matmarex renamed this task from Pressing escape the focus is outside of the editor (e.g. the sidebar language popup is open) closes VE to Pressing Escape when the focus is outside of the editor (e.g. the sidebar language popup is open) closes VE.

matmarex mentioned this in T306763: No timeout recovery when switching between visual and source editor.

VE doesn't close when escape is pressed as expected.

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jun 15 2022, 9:00 PM

• mewoph mentioned this in T311467: [wmf.17-mobile] "Suggestions" label has no padding .Jun 28 2022, 4:57 PM

ppelberg closed this task as Resolved.Jul 8 2022, 12:57 AM

ppelberg claimed this task.

Pressing Escape when the focus is outside of the editor (e.g. the sidebar language popup is open) closes VEClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Pressing Escape when the focus is outside of the editor (e.g. the sidebar language popup is open) closes VE
Closed, ResolvedPublic
Actions