Page MenuHomePhabricator

"Main Page" link is removed in vectorTabs
Closed, InvalidPublic

Description

The text "Main Page" in some language wikipedias appears as a broken text instead of a hyper link. Some script overwrites the vectorTab caption as plain text as opposed to be a hyper link.

Screenshot:- http://tawp.in/r/2bgy regarding the problem.

This bug is present in Tamil,Telugu wikipedias and other wiki-sister projects.

http://ta.wikipedia.org
http://ta.wiktionary.org
http://te.wikipedia.org

and possibly many more. However not all language Wikis have this problem, Malayalam and Bengali seems to work fine.


Version: unspecified
Severity: normal

Details

Reference
bz29076

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:25 PM
bzimport set Reference to bz29076.

sodabottle wrote:

(In reply to comment #0)

The text "Main Page" in some language wikipedias appears as a broken text
instead of a hyper link. Some script overwrites the vectorTab caption as plain
text as opposed to be a hyper link.
Screenshot:- http://tawp.in/r/2bgy regarding the problem.
This bug is present in Tamil,Telugu wikipedias and other wiki-sister projects.
http://ta.wikipedia.org
http://ta.wiktionary.org
http://te.wikipedia.org
and possibly many more. However not all language Wikis have this problem,
Malayalam and Bengali seems to work fine.

:This problem is because of the updates to "Main Page layout fixes" in common.js maintained by [[User:AzaToth]], [[User:R. Koot]], [[User:Alex Smotrov]] not being propagated to the wikis in question. Wikis still using the "mainPageRenameNamespaceTab" function (which is loaded by the "addOnloadHook") will face this problem. I have put in a fix for ta wiki, but i guess, we will have to completely rewrite common.js to be in sync with enwiki and other leading wikis

This is happening due to a local script which assummed the <span> element was the only element inside the <li> tag, and overwrite the inner contents.

This removed the <a> tag inside the <span> for skins like Vector.

Instead the script should look for the <a> tag and replace the text of tag. That way the script will be shorter and it will work in both Vector and Monobook.

See also http://www.mediawiki.org/wiki/Snippets/Main_Page_tab

I've applied the fix.