Page MenuHomePhabricator

Determine if Coffee Roll on Talk Page should have an indicator to read more
Closed, ResolvedPublic

Description

Background
The Discussion Tools was improved to display the coffee roll. The original design and its implementation isn't consistent. The designer should evaluate if sticking to the original design is worth the space that may be lost by adding Read More, or if it is important to prioritize new users who may not understand how the coffee roll works if there isn't an indicator to expand that portion of the page.

The Task
Determine if coffee roll in Beta should be updated to match the design or if there is a third version of the coffee roll to consider.

Original Design

Screen Shot 2022-06-09 at 9.50.16 PM.png (980×348 px, 91 KB)

Implementation

WhatsApp Image 2022-06-16 at 3.20.01 PM.jpeg (1×738 px, 93 KB)

New design from @scblr

Hey @cooltey@JTannerWMF and I would like to make some updates to the coffee roll design, could you implement it like this, please:


APK: https://github.com/wikimedia/apps-android-wikipedia/pull/3464

Event Timeline

Thanks for creating the task @JTannerWMF. After looking at it with fresh eyes, I suggest keeping the designs simple, like this:

The things that have changed compared to the screenshot in the task’s description:

  • Use the entire width of the screen w/o a border or box
  • Increase font-size to 14sp and 24sp line-height (font_group_4)

@cooltey — please make sure to update the side panel in T299033 accordingly, thanks!

Hi @scblr

Please check the APK from the ticket description (the same APK in T299033) to see if it works for you.

Screenshot_20220627-161620_Wikipedia Dev.jpg (2×1 px, 430 KB)
Screenshot_20220627-161626_Wikipedia Dev.jpg (2×1 px, 370 KB)

Added comments related to the coffee roll to T299033#8032181.

@cooltey – I just downloaded the APK you mentioned but can’t see a coffee roll, e.g., on the Couscous or Climate Change talk page:

https://www.dropbox.com/s/sv42cstpox4r7yc/screen-20220707-104744.mp4?dl=0

Hi @scblr

I just downloaded the APK you mentioned but can’t see a coffee roll, e.g., on the Couscous or Climate Change talk page:

It was the Github CI build failure. Now you can download the latest APK from the link.

@cooltey hmm, it’s still the same – coffee roll’s not visible:

Screenshot_20220708-111110.png (2×1 px, 458 KB)

... am I missing something?


Side note/observation:

I noticed that the Date published option does not update the list properly – is that related to the APK or a bug? See this video:

https://www.dropbox.com/s/vogtcgylgkkm5q4/screen-20220708-111247.mp4?dl=0

@cooltey hmm, it’s still the same – coffee roll’s not visible:

Screenshot_20220708-111110.png (2×1 px, 458 KB)

... am I missing something?


Side note/observation:

I noticed that the Date published option does not update the list properly – is that related to the APK or a bug? See this video:

https://www.dropbox.com/s/vogtcgylgkkm5q4/screen-20220708-111247.mp4?dl=0

Hi @scblr

Please download the APK again from this PR: https://github.com/wikimedia/apps-android-wikipedia/pull/3464

The logic of showing the coffee roll in the discussiontool API has been changed yesterday 😿, that's why you didn't see it. Please try again.

Mentioning it here for traceability: there’s a bug with the coffee roll and @cooltey filed a task for it: T313850

Visual for the bug mentioned in the previous comment from T299033#8104360

02) Not quite sure why the first topic on this user talk page is outputted as a coffee roll. Do you know why? Thanks for the insights.

Screenshot_20220726-142919.png (2×1 px, 243 KB)
Screenshot_20220726-143352.png (2×1 px, 41 KB)