| • alexhollender_WMF | |
| Jun 16 2022, 9:07 PM |
| F35498226: Screen Shot 2022-08-30 at 11.06.47 AM.png | |
| Aug 30 2022, 6:06 PM |
| F35491761: Screen Shot 2022-08-26 at 12.27.29 PM.png | |
| Aug 26 2022, 4:28 PM |
| Restricted File | |
| Aug 18 2022, 9:39 PM |
| F35477064: tab.mov-E8148BD2-9AAA-4A03-96FB-CA87378EA691.gif | |
| Aug 18 2022, 9:30 PM |
| F35477298: Screen Recording 2022-08-18 at 4.17.24 PM.mov-65D59D48-2643-4583-947D-B437EA9BA577.gif | |
| Aug 18 2022, 9:30 PM |
| F35476997: underline.mov-BC6F2770-AD0A-4937-A0B6-0EF70AAA1186.gif | |
| Aug 18 2022, 9:30 PM |
| F35477158: Screen Recording 2022-08-18 at 3.44.29 PM.mov-2B365FA2-C14C-41C6-B5A9-9D826375C44A.gif | |
| Aug 18 2022, 9:30 PM |
| Restricted File | |
| Jun 22 2022, 10:46 PM |
Because Watch (☆) is not a tab it should not get an underline on hover:
| current | updated |
 |  |
The wikilove icon also has this, (as shown on user pages)
{F35265879}
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ovasileva | T303549 Move titlebar above toolbar | |||
| Resolved | ovasileva | T309398 Article toolbar styling | |||
| Resolved | ovasileva | T310838 Watch (☆) and Wikilove button in toolbar should not have an underline on hover |
@alexhollender_WMF if we're making visual changes here, might I suggest we also do T234990 while we are here?
Change 807600 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Remove hover and focus states on article toolbar links
Change 807654 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Remove hover effect on icon tabs
I looked into this and I think we should go with the quick fix here. Both of these icons have the non standard "icon" class which we can use to distinguish them from the others. We can revisit in quarter 1 when we work on the more dropdown. I'll leave a comment on T234990 with what we can do in quarter 1.
Change 807654 abandoned by Jdlrobson:
[mediawiki/skins/Vector@master] Remove hover effect on icon tabs
Reason:
This is no longer working since Jan's recent refactoring. Hopefully not too hard to get it working again.
Change 814234 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@master] Refactor chevron implementation across components
Change 814234 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@master] Refactor chevron across components + separate watchstar
Change 814234 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Refactor chevron across components + separate watchstar
QA:
Macbook Pro
Chrome
Vector 2022
Clip from https://en.wikipedia.org/wiki/User_talk:Vdubs81
There is an underline under Wikilove icon on hover:
@Jdlrobson is this ticket just for Vector 2010 or does scope of this ticket also cover Vector 2022?
One note, in Vector 2022, there is currently no active outline shown when tabbing to Wikilove icon on user pages, though because the underline is still displaying, the user can see that the Wikilove icon is active. I am not sure if this existed before this ticket or not, so this may be out of scope, but am noting it here. clip from https://en.wikipedia.org/wiki/User_talk:Vdubs81 :
{F35477319}
@vaughnwalters Scope of this ticket should be Vector 2022 only. Vector legacy is unaffected.
Change 824303 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] [WIP] Visual enhancements: Icons
Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/dcb2317c72/w
as far as I can tell the watchstar already doesn't have an underline on hover. how can I test the wikilove button in patchdemo?
@alexhollender_WMF you can use https://patchdemo.wmflabs.org/wikis/dcb2317c72/w/index.php?title=User:Bob&useskin=vector-2022 (but log in first as Patch demo)
You need to log in as a user other than Bob. The Wikilove symbol only shows on user pages that are not you.
Try https://patchdemo.wmflabs.org/wikis/dcb2317c72/w/index.php?title=User:Patch_Demo&useskin=vector-2022
I can't figure it out. Can you post a screenshot while hovering and then move to sign-off?
Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fc355bcae6/w
Confirming no underline on hover for watchstar. For wikilove button, that will be handled in T234990: Replace 'watchstar' and 'wikilove' icon with WikimediaUI default. Resolving.
Change 824303 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Icons: Watchstar and wikilove are upgraded
Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:
Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:
