Page MenuHomePhabricator

Do not grey out page title when in edit mode (Vector 2022)
Closed, ResolvedPublic0 Estimated Story Points

Description

Description

Now that we have moved the VE toolbar below the page title we no longer need to grey out the page title in order to communicate that it is not editable.

currentupdated
Group.jpg (822×1 px, 391 KB)
Group Copy.jpg (822×1 px, 392 KB)

Notes

approval from Editing-team: T310197#8010152

Event Timeline

@alexhollender_WMF is this for all skins, or just the new Vector? if the new Vector what's the reasoning for keeping the old one the same?

Change 807232 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/skins/Vector@master] Use the data-ve-target-container attribute to position VE

https://gerrit.wikimedia.org/r/807232

(Note if this is Vector 2022 only this is fixed by the fix for T310197.)

Jdlrobson triaged this task as Medium priority.Wed, Jun 22, 12:17 AM
Jdlrobson set the point value for this task to 0.
alexhollender_WMF renamed this task from Do not grey out page title when in edit mode to Do not grey out page title when in edit mode (Vector 2022).Wed, Jun 22, 7:43 PM

@alexhollender_WMF is this for all skins, or just the new Vector? if the new Vector what's the reasoning for keeping the old one the same?

Vector 2022 only

Change 807655 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Do not grey out page title while loading on Vector 2022

https://gerrit.wikimedia.org/r/807655

While testing the VE patch, I noticed that the title was still being greyed out while the editor was loading (but not after it was loaded). My patch above resolves this issue.

BeforeAfter

@alexhollender_WMF this should be testable shortly on the beta cluster https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?action=edit
Please move to needs more work or sign off depending on how your testing goes.

Change 807232 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use the data-ve-target-container attribute to position VE

https://gerrit.wikimedia.org/r/807232

thanks for catching that @matmarex.

@alexhollender_WMF this should be testable shortly on the beta cluster https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?action=edit
Please move to needs more work or sign off depending on how your testing goes.

what I'm seeing on beta does not match what @matmarex posted in T310839#8021563. notice that while the editor is loading the page title and toolbar are greyed out:

Change 807655 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Do not grey out page title while loading on Vector 2022

https://gerrit.wikimedia.org/r/807655

@Jdlrobson where should I test this? I'm not seeing any changes from yesterday on beta

Patch got merged 8 minutes ago, so will hopefully be on the beta cluster shortly.

Looks good, resolving! From the beta cluster:

Screen Shot 2022-06-27 at 12.21.11 PM.png (625×1 px, 345 KB)

ovasileva claimed this task.

Change 809308 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.17] Do not grey out page title while loading on Vector 2022

https://gerrit.wikimedia.org/r/809308

Change 809308 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.39.0-wmf.17] Do not grey out page title while loading on Vector 2022

https://gerrit.wikimedia.org/r/809308

Mentioned in SAL (#wikimedia-operations) [2022-06-28T23:20:37Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.17/extensions/VisualEditor/modules/ve-mw/preinit: Backport: [[gerrit:809308|Do not grey out page title while loading on Vector 2022 (T310839)]] (duration: 03m 28s)