Maniphest T310865

Temporarily fork the BookletLayout class
Closed, ResolvedPublic
Actions

Description

The goal of this task is to completely decouple the transclusion dialog from the base BookletLayout, while making only simple code changes and not affecting behavior.

Copy BookletLayout.js to a new class under VisualEditor/modules/ve-mw/ui/layouts (new directory). Give the class a name specific to its purpose (eg "ve.ui.TwoPaneTransclusionLayout", since we will be stripping out the generalized "booklet" functionality.
Copy relevant stylesheet entries to a new file, with CSS class names corresponding to the new JS class.
Refactor VE customized styles to use the new CSS class names.
Refactor MWTemplateDialog to initialize this.bookletLayout to the new JS class.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Switch to forked BookletLayout	mediawiki/extensions/VisualEditor	master	+15 -13
	Copy BookletLayout implementation from ooui-js 0.44.0	mediawiki/extensions/VisualEditor	master	+616 -0
	Copy over BookletLayout styles	mediawiki/extensions/VisualEditor	master	+44 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T289653 Screenreader support for the new VisualEditor template editor sidebar
		Resolved		thiemowmde	T290262 Add keyboard shortcuts for VE template dialog
		Open		None	T294521 Finishing touches on keyboard shortcuts in the new template dialog
		Resolved		thiemowmde	T299490 Add shortcuts to hover tooltips on buttons in adv toolbar
		Resolved		thiemowmde	T289043 [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane
		Resolved		thiemowmde	T290975 Synchronize scroll and focus when template dialog is in narrow-screen mode
		Resolved		Lena_WMDE	T299036 VE Dialog: Clicking template or parameter name scrolls it to top of dialog
		Resolved		awight	T289049 Disconnect old sidebar from VE template dialog
		Resolved		awight	T310865 Temporarily fork the BookletLayout class

Event Timeline

awight created this task.Jun 17 2022, 9:32 AM

awight updated the task description. (Show Details)Jun 17 2022, 9:37 AM

awight claimed this task.Jun 20 2022, 12:27 PM

awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-08 board.

Change 806906 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Copy BookletLayout.js and rename

https://gerrit.wikimedia.org/r/806906

gerritbot added a project: Patch-For-Review.Jun 20 2022, 12:49 PM

Change 806911 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Copy over BookletLayout styles

https://gerrit.wikimedia.org/r/806911

Change 806912 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Switch to forked BookletLayout

https://gerrit.wikimedia.org/r/806912

awight removed awight as the assignee of this task.Jun 20 2022, 2:19 PM

awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-06-08 board.

Change 806911 abandoned by Awight:

[mediawiki/extensions/VisualEditor@master] Copy over BookletLayout styles

Reason:

I'll squash this with its predecessor since they are coupled in interesting ways (renaming the class)

https://gerrit.wikimedia.org/r/806911

Change 806906 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Copy BookletLayout implementation from ooui-js 0.44.0

https://gerrit.wikimedia.org/r/806906

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 21 2022, 3:00 PM

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-06-22.Jun 22 2022, 8:10 AM

Tobi_WMDE_SW moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-06-22 board.Jun 22 2022, 8:10 AM

Lena_WMDE moved this task from Backlog to In sprint on the WMDE-Templates-FocusArea board.Jun 22 2022, 8:18 AM

Change 806912 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Switch to forked BookletLayout

https://gerrit.wikimedia.org/r/806912

Maintenance_bot removed a project: Patch-For-Review.Jun 23 2022, 9:30 AM

awight closed this task as Resolved.Jun 23 2022, 10:44 AM

awight claimed this task.

awight moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-06-22 board.

Change 807939 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Add initial tests for ve.ui.MWTwoPaneTransclusionDialogLayout

https://gerrit.wikimedia.org/r/807939

gerritbot added a project: Patch-For-Review.Jun 23 2022, 11:12 AM