Page MenuHomePhabricator
Create Task
Maniphest T310866

Remove outlineSelectWidget from forked BookletLayout
Closed, ResolvedPublic
Actions

Description

We no longer want to maintain the separate OO.ui.PanelLayout this.outlineSelectWidget, but it's tightly coupled with the calling usages and with the event wiring.

  • Remove this.outlineSelectWidget
  • May require some changes to or even forking the OO.ui.OutlineControlsWidget
  • findClosestPage will need to be rewritten.
  • Rewire events which depended on this element.
  • Refactor callers which depended on getOutline. For example, this.bookletLayout.getOutline().items.forEach will have to rely on a different data source for the items.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Jun 17 2022, 9:48 AM
gerritbot added a comment.Jun 20 2022, 7:58 AM

Change 806855 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Clear all old BookletLayout OutlineItems

https://gerrit.wikimedia.org/r/806855

gerritbot added a project: Patch-For-Review.Jun 20 2022, 7:58 AM
gerritbot added a comment.Jun 20 2022, 9:12 AM

Change 806859 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove invisible stuff from BookletLayout OutlineItems

https://gerrit.wikimedia.org/r/806859

gerritbot added a comment.Jun 20 2022, 10:09 AM

Change 806859 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove invisible stuff from BookletLayout OutlineItems

https://gerrit.wikimedia.org/r/806859

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 20 2022, 11:00 AM
gerritbot added a comment.Jun 21 2022, 12:46 PM

Change 807120 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Never attach outlineSelectWidget to the DOM

https://gerrit.wikimedia.org/r/807120

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2022-06-22.Jun 22 2022, 8:12 AM
Lena_WMDE moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.Jun 22 2022, 8:18 AM
Lena_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
gerritbot added a comment.Jun 22 2022, 12:00 PM

Change 807525 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Begin disconnecting outlineSelectWidget

https://gerrit.wikimedia.org/r/807525

gerritbot added a comment.Jun 23 2022, 11:24 AM

Change 807120 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Never attach outlineSelectWidget to the DOM

https://gerrit.wikimedia.org/r/807120

awight added a comment.Jun 23 2022, 11:29 AM

It looks like we'll want to fork the OutlineControlsWidget, it's tightly coupled to OutlineSelectWidget and we've already overridden most of its built-in functionality anyway.

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.18; 2022-06-27); removed MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 23 2022, 12:00 PM
thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.Jun 24 2022, 8:08 AM
gerritbot added a comment.Jun 27 2022, 9:35 AM

Change 808831 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Remove findClosestPage logic

https://gerrit.wikimedia.org/r/808831

gerritbot added a comment.Jun 27 2022, 10:10 AM

Change 808847 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Simplify focusing a parameter

https://gerrit.wikimedia.org/r/808847

gerritbot added a comment.Jun 27 2022, 10:32 AM

Change 808855 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Remove unused parameter to `focus`

https://gerrit.wikimedia.org/r/808855

gerritbot added a comment.Jun 27 2022, 11:44 AM

Change 808873 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Remove unused resetScroll function

https://gerrit.wikimedia.org/r/808873

gerritbot added a comment.Jun 27 2022, 12:15 PM

Change 808879 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Remove broken code to focus first input

https://gerrit.wikimedia.org/r/808879

gerritbot added a comment.Jun 27 2022, 12:33 PM

Change 808881 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Move sidebar event handlers into forked class

https://gerrit.wikimedia.org/r/808881

gerritbot added a comment.Jun 27 2022, 12:52 PM

Change 808887 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Hide access to outlineSelectWidget

https://gerrit.wikimedia.org/r/808887

gerritbot added a comment.Jun 27 2022, 1:18 PM

Change 808831 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove findClosestPage logic

https://gerrit.wikimedia.org/r/808831

gerritbot added a comment.Jun 27 2022, 1:28 PM

Change 808847 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Simplify focusing a parameter

https://gerrit.wikimedia.org/r/808847

gerritbot added a comment.Jun 27 2022, 3:11 PM

Change 808873 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove unused resetScroll function

https://gerrit.wikimedia.org/r/808873

gerritbot added a comment.Jun 28 2022, 8:44 AM

Change 808855 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove unused parameter to `focus`

https://gerrit.wikimedia.org/r/808855

gerritbot added a comment.Jun 28 2022, 9:19 AM

Change 808879 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove old code to focus first input

https://gerrit.wikimedia.org/r/808879

gerritbot added a comment.Jun 28 2022, 12:54 PM

Change 808881 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Move last remaining sidebar event handler into forked class

https://gerrit.wikimedia.org/r/808881

gerritbot added a comment.Jun 28 2022, 1:32 PM

Change 808887 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Hide access to outlineSelectWidget

https://gerrit.wikimedia.org/r/808887

gerritbot added a comment.Jun 29 2022, 7:56 AM

Change 809532 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] [WIP] Remove outlineSelectWidget (old sidebar)

https://gerrit.wikimedia.org/r/809532

awight moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2022-06-22 board.Jun 29 2022, 10:32 AM
gerritbot added a comment.Jun 30 2022, 7:03 AM

Change 809532 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove outlineSelectWidget (old sidebar)

https://gerrit.wikimedia.org/r/809532

gerritbot added a comment.Jun 30 2022, 7:04 AM

Change 806855 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove all BookletLayout OutlineItem code

https://gerrit.wikimedia.org/r/806855

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 30 2022, 3:28 PM
WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-06-22 board.Jul 1 2022, 10:28 AM
WMDE-Fisch removed a project: Patch-For-Review.
WMDE-Fisch subscribed.

Looks like the main work is done. Dealing with regressions separately.

awight closed this task as Resolved.Jul 4 2022, 1:57 PM
awight claimed this task.
awight closed subtask T311296: Decouple forked OutlineControlsWidget from OutlineSelectWidget and merge in our customizations as Resolved.
awight closed subtask T311223: Fork OutlineControlsWidget as Resolved.
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.21; 2022-07-18); removed MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jul 11 2022, 8:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL