We have lots of calls like dialog.bookletLayout.stackLayout.getItems().forEach . No code in MWTemplateDialog or MWTransclusionDialog should have to know about bookletLayout's children. Push the interface up into the bookletLayout (or even into MWTemplateDialog), to look like dialog.getContentItems().
Build this on top of the forked TwoPaneTemplateDialogLayout.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T289653 Screenreader support for the new VisualEditor template editor sidebar | |||
| Resolved | thiemowmde | T290262 Add keyboard shortcuts for VE template dialog | |||
| Open | None | T294521 Finishing touches on keyboard shortcuts in the new template dialog | |||
| Resolved | thiemowmde | T299490 Add shortcuts to hover tooltips on buttons in adv toolbar | |||
| Resolved | thiemowmde | T289043 [Epic] Synchronize scroll, highlight, and focus in new VE template dialog sidebar and content pane | |||
| Resolved | thiemowmde | T290975 Synchronize scroll and focus when template dialog is in narrow-screen mode | |||
| Resolved | Lena_WMDE | T299036 VE Dialog: Clicking template or parameter name scrolls it to top of dialog | |||
| Resolved | awight | T289049 Disconnect old sidebar from VE template dialog | |||
| Resolved | awight | T310867 Cleanup: Hide knowledge about bookletLayout children |
Change 807120 had a related patch set uploaded (by Awight; author: Awight):
[mediawiki/extensions/VisualEditor@master] Never attach outlineSelectWidget to the DOM
Change 807123 had a related patch set uploaded (by Awight; author: Awight):
[mediawiki/extensions/VisualEditor@master] Drop template dialog debug container
Change 807131 had a related patch set uploaded (by Awight; author: Awight):
[mediawiki/extensions/VisualEditor@master] Push ownership of the sidebar down into the two-pane layout
Change 807134 had a related patch set uploaded (by Awight; author: Awight):
[mediawiki/extensions/VisualEditor@master] Drop unused configuration options for the two-pane layout
Change 807134 abandoned by Awight:
[mediawiki/extensions/VisualEditor@master] Drop unused configuration options for the two-pane layout
Reason:
This was wrong, "outlined" is used by TemplateDialog vs TransclusionDialog
Change 807136 had a related patch set uploaded (by Awight; author: Awight):
[mediawiki/extensions/VisualEditor@master] Drop unused "continuous" configuration
Change 807918 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Drop unused "editable" configuration from template dialog
Change 807920 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Remove unused "autoFocus" configuration from template dialog
Change 807936 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/VisualEditor@master] Remove unused events from forked BookletLayout
Change 807120 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Never attach outlineSelectWidget to the DOM
Change 807136 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Drop unused "continuous" configuration
Change 807920 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Reduce barely used "autoFocus" code in template dialog
Change 807936 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Remove unused events from forked BookletLayout
Change 807918 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Drop unused "editable" configuration from template dialog
Change 807123 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Move template dialog sidebar container into forked BookletLayout
Should we replace this usage as well?
setTimeout( function () {
dialog.bookletLayout.stackLayout.getItems().forEach( function ( page ) {
if ( page instanceof ve.ui.MWParameterPage ) {
page.updateSize();
}
} );
}, OO.ui.theme.getDialogTransitionDuration() );I had a patch for this but gave up on it for the moment: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/807476
Change 811587 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):
[mediawiki/extensions/VisualEditor@master] Don't access the stacklayout directly
Change 811587 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't access the stacklayout directly