Page MenuHomePhabricator

Review existing wikitext-based mentor lists for inconsistencies/errors
Closed, ResolvedPublic

Description

Background

As part of T264343: Have a special page for mentors to sign up, the Growth team is working on a sign up form for mentors. We decided to create a structured mentor list, MediaWiki:GrowthMentors.json, to serve as the new canonical location for the list of mentors, similar to what community configuration does.

Task objective

Before we migrate to the structured mentor lists, we should review existing wikitext-based mentor lists for potential inconsistencies or errors. This is to avoid migrating a state that's not in fact wanted by the communities.

mwscript ../../../home/urbanecm/migrateWikitextMentorList.php --wiki=cswiki --dry-run can be used from mwmaint1002 to retrieve the would-be saved mentor list.

Event Timeline

Urbanecm_WMF changed the task status from Open to In Progress.Aug 11 2022, 11:05 AM

While working on this task, I came up with this notebook.

Observations
  • ✅arwiki: Bachounda is in both mentor lists (automatic and manual). Treated as automatically assigned, is that intended? (fixed)
  • ✅ azwiki: Dancewithdevil was in the mentorlist with lowercase first character, resulted in message discarded (fixed)
  • ✅frwiktionary: XX was in the mentor list with lowercase first character, resulted in message discarded (fixed)
  • ❗kswiki: Uses a teahouse-format list of mentors. Might not be happy about the switch to structured mentor list (FYI @KStoller-WMF @Trizek-WMF).
  • ❗kswiki: Only one mentor is recognized (511KeV), other one is not. Not sure why now.
  • ✅ptwiki: Tawan Silva Mendes has a too-long message (~700 chars), will cause issues after switch. Will be caught by migration script, and can be fixed by manually truncating the message as-of deployment (OK to do during deployment per @Trizek-WMF).
  • ✅svwiki: Instead of |, they use a different character to separate mentor name and message (a dot: ). Invervention will be required before deployment (so structured list has correct data). Fixed.
Bugs
  • ✅ Message specified in the manual list is not present. This will be fixed by T291564. Affects arwiki and enwiki at least. For rollout to pilots, this is not a blocker, because only arwiki and cswiki make use of the manual list of mentors, and only arwiki has mentor messages in there (ie. the issue can be easily workarounded during deployment).

Review done, keeping opened to ensure the ❗ items from T310906#8153006 are addressed. Fortunately, doesn't affect any pilots, and from technical perspective, should be easily fixable when we're ready for deployment. Not sure whether kswiki will be happy about the structured list though, because of how their list of mentors looks like (might be a part of teahouse or similar), see https://ks.wikipedia.org/wiki/%D9%88%D9%90%DA%A9%DB%8C%D9%96%D9%BE%DB%8C%D9%96%DA%88%DB%8C%D8%A7:%DA%86%D8%A7%D8%A6%DB%92_%D8%AC%D8%A7%D8%A6%DB%92/Hosts.

Urbanecm_WMF changed the task status from In Progress to Open.Aug 15 2022, 5:50 PM

@Urbanecm_WMF, sorry for the delay, this task didn't showed up on my radar.

kswiki is an interesting case. They apparently created a teahouse and turned on our feature at the same time. I will contact them when time comes for the deployment of the structured list.

Tawan Silva Mendes' case may not be the only one, but as they aren't following the instructions we provide, it is fine to truncate the message.

svwiki is now fixed.

Thanks for having a look @Trizek-WMF! Do you want to keep this task open to track kswiki's mentor list? Or can this be closed as Resolved, given the review itself happened successfully?

I reported the kswiki case to my task regarding the deployment.