Page MenuHomePhabricator

Tag edits made to MediaWiki:GrowthMentors.json via action=growthmanagementorlist
Closed, ResolvedPublic

Description

Background

As part of T264343: Have a special page for mentors to sign up, the Growth team is working on a sign up form for mentors. We decided to create a structured mentor list, MediaWiki:GrowthMentors.json, to serve as the new canonical location for the list of mentors, similar to what community configuration does. Mentors will be able to change their information, and non-mentors will be able to enroll (so long they meet requirements to sign up).

This task serves a similar purpose as T310912: MediaWiki:GrowthMentors.json should have a notice about edits made by non-admins. Because both solutions are fully separate, filling two tasks for easier tracking.

Acceptance criteria
  • Edits made to MediaWiki:GrowthMentors.json via action=growthmanagementorlist will be tagged via a dedicated tag

Event Timeline

Change 806530 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigWriter: Support tagging edits

https://gerrit.wikimedia.org/r/806530

Change 806531 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] StructuredMentorWriter: Tag edits made by the writer

https://gerrit.wikimedia.org/r/806531

If I understand correctly, non-admins will be able to edit the Mediawiki page thought their Mentor dashboard. Which limits the potentiality of bad edits, and prevents editing other mentors' descriptions.

If the idea is to have more eyes on the mentors' list, to check who signs up and who edits what, maybe we should add some indications about recent changes to the list:

Capture d’écran_2022-06-21_14-56-04.png (330×555 px, 38 KB)

The wording you use is

Change of the mentor list

We know it is on the mentor list, as the edit targets the list. However, we don't know how a non-admin edits the list.

I think it would be more clear if you go with:

Change made using the MentorDashboard

If I understand correctly, non-admins will be able to edit the Mediawiki page thought their Mentor dashboard. Which limits the potentiality of bad edits, and prevents editing other mentors' descriptions.

Yes, that's the intention.

If the idea is to have more eyes on the mentors' list, to check who signs up and who edits what, maybe we should add some indications about recent changes to the list:

Capture d’écran_2022-06-21_14-56-04.png (330×555 px, 38 KB)

Unfortunately, I don't see that image. Do you mind changing its visibility to Public please? See T310833 and Slack for details about the recent change.

The wording you use is

Change of the mentor list

We know it is on the mentor list, as the edit targets the list. However, we don't know how a non-admin edits the list.

I think it would be more clear if you go with:

Change made using the MentorDashboard

Thanks for the suggestion. My idea is to tag all edits that went through GrowthExperiments, rather than just those that came through the mentor dashboard. For instance, I wnat to tag edits made by an admin via Special:ManageMentors when removing a mentor as well as edits made by mentors via their dashboard. Happy to change the tag name to something better if you have any suggestions! We can also decide to just tag edits coming through the mentor dashboard, if we think that's a better option.

Sorry for the image, @Urbanecm_WMF. I forgot about this permission issue.

I think we should only tags coming from the Mentor Dashboard, as it is a special action. Regular actions performed by admins are like any other edit on the Mediawiki namespace.

Change 806530 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigWriter: Support tagging edits

https://gerrit.wikimedia.org/r/806530

Sorry for the image, @Urbanecm_WMF. I forgot about this permission issue.

No problem, thanks for the fix. I can see it now.

I think we should only tags coming from the Mentor Dashboard, as it is a special action. Regular actions performed by admins are like any other edit on the Mediawiki namespace.

I see. I think this means we'd have to get a new tag when we decide to allow non-admins to edit the list in some other way (not sure if another way is likely to come). It also means that if a wiki decides to open Special:ManageMentors to non-admins [1], such edits won't be tagged, even though they would have the same issue as dashboard-powered edits.

Generally speaking, I think it's useful to be able to tell apart an edit done by software (even when done by an admin) and an edit done manually by the editing admin. I believe that's useful in case our editor has bugs (it'd be obvious it's GrowthExperiments codebase to blame, rather than the individual admin).

Taking those points together, I feel like a generic "made by GrowthExperiments" tag is better than "made by mentor dashboard". However, if you think we should just tag the dashboard originating edits and resolve the other potential issues I described above in the future (in case they come to us), that's also fine with me.

@Urbanecm_WMF, as the question it to highlight edits made on the page, then we should tag everything. My question was mostly around differentiating edits made by non-admins from edits made by admins.

Thanks for the answer. I decided to go ahead with the current global tag, for now. In case a need to tell apart edits made by admins and non-admins arises, we can always change it/add other tags.

Change 806531 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] StructuredMentorWriter: Tag edits made by the writer

https://gerrit.wikimedia.org/r/806531

Checked on enwiki.betalabs works as expected.

mentor list change tag is present in RC and in View history of [[ MediaWiki:GrowthMentors.json | https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:GrowthMentors.json ]]

For production - waiting for https://phabricator.wikimedia.org/T264343

The tag mentor list change is present on Special:Tags list (e.g. cs:Special:Tags, but the tag's status is non-active in production and on in beta cluster.

MediaWiki:Tag-mentor list change page doesn't exist yet in beta cluster or in production wikis (wmf.21).

mentor list change works as expected in testwiki wmf.23.