Page MenuHomePhabricator

Site logo cropped/not fully displayed on some projects
Open, Needs TriagePublicBUG REPORT

Assigned To
None
Authored By
1234qwer1234qwer4
Jun 19 2022, 2:56 PM
Referenced Files
F35262709: WikiSpecies_logo.svg
Jun 22 2022, 7:49 AM
F35253423: logo crop 3.png
Jun 19 2022, 2:56 PM
F35253422: logo crop 2.png
Jun 19 2022, 2:56 PM
F35253419: logo crop 1.png
Jun 19 2022, 2:56 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The logo on Wikispecies is cropped vertically in Monobook; on srwikisource it is cropped on both skins.

What should have happened instead?:
Logo should be displayed correctly

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.: Wikispecies logo in Monobook:

logo crop 1.png (810×2 px, 689 KB)

srwikisource logo on Monobook and Vector:
logo crop 2.png (605×2 px, 127 KB)

logo crop 3.png (636×2 px, 136 KB)

Tested on Firefox (version 101) and Edge. Seems to happen for zoom levels greater than 90 % in Firefox for me (16:9 monitor).

Event Timeline

As the one updated the logo of Wikispecies in T306037: the reason is that the width-height ratio of corresponding SVG file failed to match the recommended 135px:155px standard. I made a new version in F35262709, hope someone (maybe @1234qwer1234qwer4 you could do so as a commons admin) to do a reupload, and I could submit a patch to update the static file in mediawiki-config repository.

Thanks. Your file appears to be 135x150; could that still cause issues?

Per Manual:$wgLogos the height should be less than 155px when width is 135px, so I thought it's fine.

Change 807491 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] specieswiki: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/807491

Change 807491 merged by jenkins-bot:

[operations/mediawiki-config@master] specieswiki: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/807491

Mentioned in SAL (#wikimedia-operations) [2022-06-22T13:53:16Z] <lucaswerkmeister-wmde@deploy1002> Synchronized static/images/project-logos/: Config: [[gerrit:807491|specieswiki: Adjust width-height ratio of logo to fix display issue (T310961)]] (1/3) (duration: 03m 46s)

Mentioned in SAL (#wikimedia-operations) [2022-06-22T13:57:24Z] <lucaswerkmeister-wmde@deploy1002> Synchronized logos/config.yaml: Config: [[gerrit:807491|specieswiki: Adjust width-height ratio of logo to fix display issue (T310961)]] (2/3) (duration: 03m 29s)

Mentioned in SAL (#wikimedia-operations) [2022-06-22T14:01:07Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/logos.php: Config: [[gerrit:807491|specieswiki: Adjust width-height ratio of logo to fix display issue (T310961)]] (3/3) (duration: 03m 30s)

Mentioned in SAL (#wikimedia-operations) [2022-06-22T14:01:33Z] <Lucas_WMDE> lucaswerkmeister-wmde@mwmaint1002:~$ printf 'https://en.wikipedia.org/static/images/project-logos/%s\n' specieswiki{,-{1.5,2}x}.png | mwscript purgeList.php # T310961

Logo for specieswiki has been updated. As for srwikisource, maybe someone else would like to give a hand.

FYI: related patch, however don't know which commons file it is.

Change 818576 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] srwikisource: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/818576

Note that this is also a problem on https://hi.wikisource.org/.

Same problem, I failed to find an SVG format logo - there's one on commons but it looks different from the actual logo used on that site.

Change 818576 merged by jenkins-bot:

[operations/mediawiki-config@master] srwikisource: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/818576

Mentioned in SAL (#wikimedia-operations) [2022-08-01T14:01:28Z] <urbanecm@deploy1002> Synchronized static/images/project-logos/: bcb7b0d4d07b454a169804d7b1011ec3f2530c00: srwikisource: Adjust width-height ratio of logo to fix display issue (T310961; 1/2) (duration: 03m 41s)

Mentioned in SAL (#wikimedia-operations) [2022-08-01T14:04:47Z] <urbanecm@deploy1002> Synchronized wmf-config/logos.php: bcb7b0d4d07b454a169804d7b1011ec3f2530c00: Adjust width-height ratio of logo to fix display issue (T310961; 2/2) (duration: 03m 17s)

srwikisource has been fixed (thanks). hiwikisource is still to be handled, and I have also found https://eu.wikisource.org/, https://be.wikisource.org/, and https://cs.wikisource.org/ with this issue.

Change 826677 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] bewikisource: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/826677

Change 826678 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] euwikisource: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/826678

Change 826679 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] cswikisource: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/826679

Change 827546 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] logos: Raise error if logo is too tall

https://gerrit.wikimedia.org/r/827546

Change 826677 merged by jenkins-bot:

[operations/mediawiki-config@master] bewikisource: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/826677

Change 826678 merged by jenkins-bot:

[operations/mediawiki-config@master] euwikisource: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/826678

Change 826679 merged by jenkins-bot:

[operations/mediawiki-config@master] cswikisource: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/826679

Mentioned in SAL (#wikimedia-operations) [2022-08-29T21:44:37Z] <tgr@deploy1002> Synchronized logos/config.yaml: Config: Adjust width-height ratio of logos for [[gerrit:826677|bewikisource]], [[gerrit:826678|euwikisource]], [[gerrit:826679|cswikisource]] to fix display issue (T310961) (duration: 03m 45s)

Mentioned in SAL (#wikimedia-operations) [2022-08-29T21:48:53Z] <tgr@deploy1002> Synchronized wmf-config/logos.php: Config: Adjust width-height ratio of logos for [[gerrit:826677|bewikisource]], [[gerrit:826678|euwikisource]], [[gerrit:826679|cswikisource]] to fix display issue (T310961) (duration: 03m 34s)

Mentioned in SAL (#wikimedia-operations) [2022-08-29T21:53:14Z] <tgr@deploy1002> Synchronized static/images/project-logos: Config: Adjust width-height ratio of logos for [[gerrit:826677|bewikisource]], [[gerrit:826678|euwikisource]], [[gerrit:826679|cswikisource]] to fix display issue (T310961) (duration: 03m 59s)

(eu|be|cs)wikisource got fixed. I also upload a patch which could raise an exception when running manage.py if selected logo is too tall.

Change 827546 merged by jenkins-bot:

[operations/mediawiki-config@master] logos: Raise error if logo is too tall

https://gerrit.wikimedia.org/r/827546

Change 841992 had a related patch set uploaded (by Stang; author: Stang):

[operations/mediawiki-config@master] yiwiktionary: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/841992

Change 841992 merged by jenkins-bot:

[operations/mediawiki-config@master] yiwiktionary: Adjust width-height ratio of logo to fix display issue

https://gerrit.wikimedia.org/r/841992

Mentioned in SAL (#wikimedia-operations) [2022-10-12T20:35:14Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:841992|yiwiktionary: Adjust width-height ratio of logo to fix display issue (T310961)]]

Mentioned in SAL (#wikimedia-operations) [2022-10-12T20:35:38Z] <samtar@deploy1002> samtar and stang: Backport for [[gerrit:841992|yiwiktionary: Adjust width-height ratio of logo to fix display issue (T310961)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2022-10-12T20:40:31Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:841992|yiwiktionary: Adjust width-height ratio of logo to fix display issue (T310961)]] (duration: 05m 17s)