🟪️ Add the Property's datatype to statement response data
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	Jakob_WMDE
	Jun 20 2022, 10:02 AM

Description

All statements in responses should include the data type of the of the Property in the mainsnak.datatype field of the statement. Note that this is different from the datavalue.type field. See https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/9b6858649d8333e664500f1635a2205f6daf28d0/docs/topics/datatypes.md

The datatype field should be required on the mainsnak field of a statement in the *response schema* . The datatype is not expected in the request data.

Related Objects
Search...

Status	Assigned	Task
Resolved	WMDE-leszek	T310993 🟪️ Add the Property's datatype to statement response data
Resolved	Jakob_WMDE	T311152 🟪️ Ensure datatype is added to all snaks in responses
Resolved	Ollie.Shotton_WMDE	T311198 🟪️ Create a SnakSerializer that adds a datatype field
Resolved	Jakob_WMDE	T311199 🟪️ Check whether it's ok to look up property datatypes one by one
Resolved	Jakob_WMDE	T311219 🟪️ Create a `SerializerFactory` for the REST API

Event Timeline

Jakob_WMDE created this task.Jun 20 2022, 10:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2022, 10:02 AM

Jakob_WMDE set the point value for this task to 5.Jun 20 2022, 10:05 AM

WMDE-leszek moved this task from Backlog to Sprint 9 on the Wikibase Product Platform (v1) board.Jun 22 2022, 10:30 AM

WMDE-leszek edited projects, added Wikibase Product Platform (v1) (Sprint 9); removed Wikibase Product Platform (v1).

Notes from task breakdown:

~~create a SnakSerializer which adds the datatype to all kinds of snaks using a PropertyDataTypeLookup @Silvan_WMDE creates ticket~~
create a SerializerFactory which can be used to create all kinds of serializers we need (currently statement list, statement, item) which internally use the new SnakSerializer @Ollie.Shotton_WMDE creates ticket
~~use all the new serializers @Jakob_WMDE creates ticket~~
- ~~mark datatype as required in the spec~~
~~do some research to check whether it's ok to look up property datatypes one by one. @Silvan_WMDE creates ticket~~

Jakob_WMDE renamed this task from Add the Property's datatype to statement response data to 🟪️ Add the Property's datatype to statement response data.Jun 22 2022, 1:47 PM

Silvan_WMDE added a project: Story.Jun 23 2022, 5:39 AM

Jakob_WMDE moved this task from To Do to Product Verification on the Wikibase Product Platform (v1) (Sprint 9) board.Jul 1 2022, 1:23 PM

Verified, thanks!

WMDE-leszek moved this task from Product Verification to Done on the Wikibase Product Platform (v1) (Sprint 9) board.Jul 4 2022, 8:53 PM

WMDE-leszek closed this task as Resolved.Jul 11 2022, 9:18 AM

WMDE-leszek claimed this task.

WMDE-leszek closed subtask T311219: 🟪️ Create a `SerializerFactory` for the REST API as Resolved.

WMDE-leszek closed subtask T311199: 🟪️ Check whether it's ok to look up property datatypes one by one as Resolved.

WMDE-leszek closed subtask T311198: 🟪️ Create a SnakSerializer that adds a datatype field as Resolved.

WMDE-leszek closed subtask T311152: 🟪️ Ensure datatype is added to all snaks in responses as Resolved.