When clicking a link to a comment repeatedly, the highlight (from DiscussionTools) grows bigger every time
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jun 20 2022, 8:44 PM

Description

When clicking a link to a comment repeatedly, the highlight (from DiscussionTools) grows bigger every time. Additionally, it doesn't disappear when clicking elsewhere on the page (instead grows a little smaller).

https://en.wikipedia.beta.wmflabs.org/wiki/Talk:T311021

Details

	Subject	Repo	Branch	Lines +/-
	Fix race condition causing highlights to not be cleared	mediawiki/extensions/DiscussionTools	master	+31 -30

Customize query in gerrit

Event Timeline

matmarex created this task.Jun 20 2022, 8:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2022, 8:44 PM

matmarex claimed this task.Jun 20 2022, 8:47 PM

matmarex updated the task description. (Show Details)

matmarex attached a referenced file: F35257089: image.png. (Show Details)

matmarex attached a referenced file: F35257087: image.png. (Show Details)

matmarex attached a referenced file: F35257083: image.png. (Show Details)

matmarex attached a referenced file: F35257081: image.png. (Show Details)

matmarex added a project: Editing-team (Kanban Board).

Change 806943 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix race condition causing highlights to not be cleared

https://gerrit.wikimedia.org/r/806943

gerritbot added a project: Patch-For-Review.Jun 20 2022, 8:52 PM

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.Jun 20 2022, 8:53 PM

Change 806943 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix race condition causing highlights to not be cleared

https://gerrit.wikimedia.org/r/806943

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 21 2022, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2022, 4:30 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jun 21 2022, 6:27 PM

matmarex added a project: Editing QA.

Before fix: https://photos.app.goo.gl/7enrVQvu6sBn4wHz5

After Fix: https://photos.app.goo.gl/NoViDwXto4svuRq49

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jun 23 2022, 9:00 PM

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.Jun 30 2022, 3:53 PM

• ppelberg closed this task as Resolved.Jul 8 2022, 12:55 AM

When clicking a link to a comment repeatedly, the highlight (from DiscussionTools) grows bigger every timeClosed, ResolvedPublicActions

Description

Details

Event Timeline

When clicking a link to a comment repeatedly, the highlight (from DiscussionTools) grows bigger every time
Closed, ResolvedPublic
Actions