Page MenuHomePhabricator

IP Info: Add help text for ASN
Closed, ResolvedPublic1 Estimated Story Points

Assigned To
Authored By
Prtksxna
Jun 21 2022, 4:14 AM
Referenced Files
F35283165: asn_popup_beta.png
Jun 28 2022, 9:09 AM
F35265190: image.png
Jun 22 2022, 5:33 PM
F35265182: image.png
Jun 22 2022, 5:33 PM
F35265187: image.png
Jun 22 2022, 5:33 PM
F35265185: image.png
Jun 22 2022, 5:33 PM
F35265170: image.png
Jun 22 2022, 5:33 PM
Restricted File
Jun 22 2022, 3:50 PM

Description

AC:

  • Add the info help icon for ASN
  • Add the following text to the help popup: A unique identifier for networks assigned to a region and further to organizations like governments and ISPs

Event Timeline

We have a slight design issue here, the help popup is melting with the sidebar text, should I fix it in this patch or create a new ticket?
cc @Tchanders

{F35264850}

Change 807591 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/IPInfo@master] Add help icon to infobox ASN

https://gerrit.wikimedia.org/r/807591

We have a slight design issue here, the help popup is melting with the sidebar text, should I fix it in this patch or create a new ticket?
cc @Tchanders

{F35264850}

The problem comes from the backwards align that we set on the help popup:

popup: {
	$content: $( '<span>' ).text( propertyTooltip ),
	padded: true,
	align: 'backwards', // <--------------- HERE
	position: 'above'
},

(from https://gerrit.wikimedia.org/g/mediawiki/extensions/IPInfo/+/dafa01ba4601bb0cb252b4ab5ddccf631542b376/modules/ext.ipInfo/widget.js#148)

We could solve this by removing the align config, but this still overlap the main menu, even on a fairly normal window width:

image.png (341×1 px, 70 KB)

Perhaps better, we could set it to 'forwards':

Left columnMiddle columnRight column
image.png (347×1 px, 71 KB)
image.png (351×1 px, 68 KB)
image.png (344×1 px, 71 KB)

RTL language:

image.png (343×1 px, 64 KB)

Change 807591 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add help icon to infobox ASN

https://gerrit.wikimedia.org/r/807591

dom_walden subscribed.

Here is what the popup looks like on beta, Vector 2022, English:

asn_popup_beta.png (339×1 px, 48 KB)

I also tested Vector 2010, Minerva, MonoBook and Timeless in French, German and Hebrew at different zoom levels.

We are using an OOUI widget so I assume it should work across different browsers.

Test environment: https://en.wikipedia.beta.wmflabs.org IP Info 0.0.0 (f2f0771) 06:39, 28 June 2022.
Test browser: Firefox 91.