Page MenuHomePhabricator
Create Task
Maniphest T311032

IP Info: Add links to block log
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

AC:

  • Add links to the relevant block log under the Active blocks heading, after the data
  • Add links only in the accordion, not in the popup
  • Link 'Logs' to: Special:Log?type=block&page=<ip>

Screen Shot 2022-06-21 at 10.33.28 AM.png (212×456 px, 14 KB)

Details

SubjectRepoBranchLines +/-
Add links to block log - always show blocks even if there are not active blocksmediawiki/extensions/IPInfomaster+5 -7
Add links to block log on infoboxmediawiki/extensions/IPInfomaster+20 -2
Customize query in gerrit

Related Objects

Event Timeline

• Prtksxna created this task.Jun 21 2022, 5:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 21 2022, 5:03 AM
• Prtksxna moved this task from Design to Triage/To be Estimated on the Anti-Harassment board.Jun 21 2022, 5:06 AM
Tchanders updated the task description. (Show Details)Jun 22 2022, 3:16 PM
Tchanders set the point value for this task to 2.Jun 22 2022, 8:55 PM
Tchanders edited projects, added Anti-Harassment (AHaT Sprint 10: The Mokorotlo); removed Anti-Harassment.
• TThoabala claimed this task.Jun 28 2022, 12:28 AM
• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 10: The Mokorotlo) board.Jun 28 2022, 7:08 AM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 11: The Fascinator); removed Anti-Harassment (AHaT Sprint 10: The Mokorotlo).Jun 28 2022, 5:20 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.
gerritbot added a comment.Jul 1 2022, 12:53 AM

Change 810125 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] IP Info: Add links to block log on infobox

https://gerrit.wikimedia.org/r/810125

gerritbot added a project: Patch-For-Review.Jul 1 2022, 12:53 AM
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Jul 1 2022, 1:17 AM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Jul 5 2022, 11:56 AM
gerritbot added a comment.Jul 5 2022, 11:56 AM

Change 810125 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add links to block log on infobox

https://gerrit.wikimedia.org/r/810125

Maintenance_bot removed a project: Patch-For-Review.Jul 5 2022, 12:30 PM
Tchanders moved this task from QA/Testing 🐞 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Jul 5 2022, 12:42 PM
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 11: The Fascinator) board.Jul 5 2022, 12:45 PM
dom_walden subscribed.Jul 5 2022, 2:48 PM

@Prtksxna The log link only appears when there is at least one active block. Is that OK? I can imagine that even if there are no active blocks a user might want to see the logs to check any past blocks.

I also notice the clickable part of the <a> element extends across the whole column (the blue area in the screenshot). Is that OK?

block_log_link.png (407×1 px, 85 KB)

• Prtksxna added a comment.Jul 6 2022, 4:18 AM
In T311032#8051958, @dom_walden wrote:

I can imagine that even if there are no active blocks a user might want to see the logs to check any past blocks.

That makes sense. I thought we didn't keep information about past blocks (at least not for too long), is that incorrect?

I also notice the clickable part of the <a> element extends across the whole column (the blue area in the screenshot). Is that OK?

Is this the case with all the links on that column? Global contribs and xtools too?

dom_walden added a comment.Jul 6 2022, 6:37 AM
In T311032#8054203, @Prtksxna wrote:
In T311032#8051958, @dom_walden wrote:

I can imagine that even if there are no active blocks a user might want to see the logs to check any past blocks.

That makes sense. I thought we didn't keep information about past blocks (at least not for too long), is that incorrect?

I think they are kept forever. I have seen block logs on enwiki going back to 2004.

I also notice the clickable part of the <a> element extends across the whole column (the blue area in the screenshot). Is that OK?

Is this the case with all the links on that column? Global contribs and xtools too?

It is the case for Global contribs and XTools as well.

• Prtksxna mentioned this in T312320: IP Info: Links in the box should only be clickable on the text.Jul 7 2022, 3:52 AM
• Prtksxna added a comment.Jul 7 2022, 3:54 AM
In T311032#8054352, @dom_walden wrote:

I think they are kept forever. I have seen block logs on enwiki going back to 2004.

In that case, yes. We should show the link even when there are no active blocks.

It is the case for Global contribs and XTools as well.

Thanks Dom! I've created T312320: IP Info: Links in the box should only be clickable on the text for this.

dom_walden added a comment.Jul 7 2022, 6:33 AM
In T311032#8058367, @Prtksxna wrote:
In T311032#8054352, @dom_walden wrote:

I think they are kept forever. I have seen block logs on enwiki going back to 2004.

In that case, yes. We should show the link even when there are no active blocks.

Flagging for the attention of @TThoabala.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 2:01 AM
ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 12: The Dutch Cap); removed Anti-Harassment (AHaT Sprint 11: The Fascinator).Jul 18 2022, 11:26 PM
ARamirez_WMF moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 12: The Dutch Cap) board.
Tchanders moved this task from QA/Testing 🐞 to In Progress 💪 on the Anti-Harassment (AHaT Sprint 12: The Dutch Cap) board.Jul 26 2022, 1:25 PM
gerritbot added a comment.Jul 26 2022, 7:40 PM

Change 817365 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/IPInfo@master] Add links to block log - always show blocks even if there are not active blocks

https://gerrit.wikimedia.org/r/817365

gerritbot added a project: Patch-For-Review.Jul 26 2022, 7:40 PM
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 12: The Dutch Cap) board.Jul 26 2022, 7:51 PM
gerritbot added a comment.Jul 27 2022, 12:27 PM

Change 817365 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add links to block log - always show blocks even if there are not active blocks

https://gerrit.wikimedia.org/r/817365

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 12: The Dutch Cap) board.Jul 27 2022, 12:29 PM
ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.23; 2022-08-01); removed MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 27 2022, 1:00 PM
dom_walden moved this task from QA/Testing 🐞 to Done Q4 2022 on the Anti-Harassment (AHaT Sprint 12: The Dutch Cap) board.Jul 28 2022, 7:37 AM
dom_walden added a subscriber: Tchanders.

The "Logs" link now appears even if there are no blocks.

logs_no_block.png (347×1 px, 45 KB)

The link it takes you to is Special:Log?type=block&page=<ip>.

@TThoabala @Tchanders I notice that it will also work if the link is Special:Log?type=block&page=User:<ip>. But, I am assuming it makes no difference. It didn't seem to when I compared them for a few IPs.

Test environment: https://en.wikipedia.beta.wmflabs.org and local docker IP Info 0.0.0 (602a002) 12:27, 27 July 2022.

Tchanders mentioned this in T314161: Add links to Special:BlockList on IPInfo.Jul 29 2022, 3:25 PM
• Prtksxna moved this task from Backlog to In Progress on the IP Info board.Aug 8 2022, 4:06 AM
• Prtksxna closed this task as Resolved.Aug 8 2022, 4:22 AM
• Prtksxna moved this task from In Progress to Future / Maybe on the IP Info board.Aug 8 2022, 4:27 AM
• Prtksxna moved this task from Future / Maybe to Closed on the IP Info board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL