Page MenuHomePhabricator

User page replacement in CheckUser block form uses the wrong ID causing issues on with dropdown selectors on itwiki.
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):
When selecting one or more users from the list of users associated with a specific IP (abusing multiple users), there is a form allowing to replace the selected user page(s) and user talk(s) with a "blocked user" template

What happens?:
Before the new UI introduction, there was a clickable option to select among different flavours of the template, separately for the user page and the user talk

This option is not shown anymore for the user page while it is present for the user talk. However, by clicking on one of the possible choices, the form field is not prepopulated with the selected template, e.g. {{BloccoInfinito}} and when clicking on the confirm button, the block is enforced but nothing is added to the selected talk. Instead, a message window is displayed reporting "missing parameter"

What should have happened instead?:

  • The options should have been displayed both for the user page(s) and the user talk(s)
  • Clicking on an option should prepopulate the corresponding filed with the template code (as a feedback to the user)
  • Confirming the operation should replace the contents of the user page(s)/talk(s) with the selected template

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Ref to https://www.mediawiki.org/wiki/Extension:CheckUser/en

  • Experienced on desktop Mac OS Monterey, Safari 15.5

Event Timeline

L736E updated the task description. (Show Details)
L736E updated the task description. (Show Details)

@L736E this is probably a Gadget or user script that does this for you. A selector for block reasons was not built in to the extension in the previous version before the change in UI. T24120 is where this dropdown feature was requested.

Change 807098 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Ensure the input for replacing the userpage has the 'blocktag' ID

https://gerrit.wikimedia.org/r/807098

In reviewing this further, MediaWiki:Group-checkuser.js on it.wiki is used to add the dropdowns to the block form. In the UI conversion, the ID was mistakenly changed to be "tag" instead of "blocktag" so the JQuery selector in that js file was not updated. Will write a patch to restore the previous ID.

Dreamy_Jazz triaged this task as High priority.

Marking as high as it breaks current functionality on WMF wikis.

Dreamy_Jazz renamed this task from extensions/CheckUser/ (it.wiki): prepopulation for user block not working properly to User page replacement in CheckUser block form uses the wrong ID causing issues on with dropdown selectors on itwiki..Jun 21 2022, 11:29 AM
Dreamy_Jazz moved this task from Patches for review to Done on the CheckUser board.

Patch has received a +2 so will be merged in. It should make the next train.

Change 807098 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Ensure the input for replacing the userpage has the 'blocktag' ID

https://gerrit.wikimedia.org/r/807098