Page MenuHomePhabricator

Audit function-orchestrator classes and methods expected input/output ZObject forms and document
Open, LowPublic

Description

There are plenty of methods that are expected to receive normal form but that might receive canonical in some cases. We need to audit the code and make sure that:

  • The expected form is clearly documented
  • The calling methods make sure that the arguments are in the expected form
  • Review the tests and make sure that they use the appropriate form

Event Timeline

Some instances where this is happening:

function-orchestrator/src/execute.js validateReturnType
function-orchestrator/src/utils.js containsValue

cmassaro subscribed.
Jdforrester-WMF lowered the priority of this task from High to Low.Jan 18 2024, 5:49 PM