Page MenuHomePhabricator

Tokens: js error when reorder items.
Closed, ResolvedPublicBUG REPORT


List of steps to reproduce (step by step, including full links if applicable):

  • Add Tokens input to form
  • add items
  • Try to drag them.
  • Try to drag them again.

What happens?:
There is error in console
Uncaught ReferenceError: i is not defined`
The next try to drag - dragging not affected.

What should have happened instead?:
No error in console, dragging working any time.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Last master commit of pagefoems (a5660810c49bd65672e17280c4c77a63a7f706da)

Event Timeline

Change 807166 had a related patch set uploaded (by Anysite; author: Anysite):

[mediawiki/extensions/PageForms@master] Combobox: Fix js error when reorder items.

Thanks for this fix. But I assume you mean "tokens", not "combobox".

Anysite renamed this task from Combobox: js error when reorder items. to Tokens: js error when reorder items..EditedJun 21 2022, 6:44 PM
Anysite updated the task description. (Show Details)

Yes, you right. editing (also in attached commit msg)

Change 807166 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Tokens: Fix js error when reorder items.

Yaron_Koren claimed this task.

Thank you for this patch!