Page MenuHomePhabricator

Civi shows duplicate PayPal donations
Closed, ResolvedPublic

Description

We've noticed some new records where the Civi record is showing two separate contributions for one donation made via PayPal.

The transaction numbers for the two transactions are the same, so we were thinking Civi is possibly just duplicating the transaction? Each of the second transactions in civi say "dup-[transactionid]" which we were thinking possibly dup = duplicate?

There are possibly many more, but the few we've spotted so far are:

ticket #CIDDate of transactionPaypal Transaction #
1131032CID 5586549506/20/20222N835366VC341811Y
1130804CID 5585176806/19/20221WA27673UX1838908
1130815CID 5585735606/19/202249A63104CP268790R

Event Timeline

This is donor-facing, as @krobinson noted they are receiving extra thank you emails.

Looks like the audit parser is incorrectly tagging some donations as legacy 'paypal' instead of 'paypal_ec'. Since we search for existing transactions based on the processor tag plus the processor-side id, this incorrect processor tag makes it look like a new donations.

We can try to fix the heuristic that the audit parser uses to decide which integration the payment came from, or we can add a special case to the import's duplicate donation handling to discard them in the import.

In any case, once we move all the existing paypal donations to braintree, the whole paypal/paypal_ec confusion will be a thing of the past.

Change 807612 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/tools@master] PayPal audit: search one-time donations under both tags

https://gerrit.wikimedia.org/r/807612

Change 807612 merged by jenkins-bot:

[wikimedia/fundraising/tools@master] PayPal audit: search one-time donations under both tags

https://gerrit.wikimedia.org/r/807612

XenoRyet set Final Story Points to 1.