Page MenuHomePhabricator

Make tokens demo flexibly stylable
Closed, ResolvedPublic

Description

Goal

The current token demos don't provide handles (CSS selectors) to style specific tokens different to others.
This ask was provided f.e. in T300562#7978614 or also in https://gerrit.wikimedia.org/r/c/design/codex/+/800084

Captura de pantalla 2022-06-03 a las 12.10.32.png (886×1 px, 328 KB)

Criteria for Done

Enable specific token selectors per token demo to be able to style specific tokens differently.

Related Objects

Event Timeline

Change 807203 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs: Update CSS class names on tokens demos

https://gerrit.wikimedia.org/r/807203

Change 807618 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] docs: Add CSS class per token demo

https://gerrit.wikimedia.org/r/807618

@Volker_E I've proposed an alternate approach that involves minimal changes—let me know what you think!

SimoneThisDot subscribed.

Moving in code review as patches are already open for this task

Change 807203 merged by jenkins-bot:

[design/codex@main] docs: Update CSS class names on tokens demos

https://gerrit.wikimedia.org/r/807203

Change 807618 abandoned by Anne Tomasevich:

[design/codex@main] docs: Add CSS class per token demo

Reason:

In favor of https://gerrit.wikimedia.org/r/c/design/codex/+/807203

https://gerrit.wikimedia.org/r/807618

@Volker_E does the merged patch address all of this task, or only some of it?

Volker_E added a subscriber: bmartinezcalvo.

That has gone under my radar. 😅 From my point of view we have everything we need.
@bmartinezcalvo anything left?

DAbad changed the task status from Open to In Progress.Sep 1 2022, 3:10 PM

Product sign-off complete