Shorten "add parameter" and "add template" button labels (VE template dialog)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Both the "add undocumented parameter" and template search components have add buttons with long labels which don't work well on mobile, especially in longer languages.

Requirements

Shorten undocumented parameter input button label to "Add"
Shorten template search button to "Add"

Note: change applies to desktop, mobile, and narrow-mode

Mocks

Screen Shot 2022-06-22 at 09.15.10.png (1×764 px, 97 KB)

Screen Shot 2022-06-22 at 09.15.53.png (1×750 px, 138 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Use "Add template" label in the sidebar and as the header	mediawiki/extensions/VisualEditor	master	+6 -3
	Shorten text for add buttons	mediawiki/extensions/VisualEditor	master	+4 -4

Customize query in gerrit

Related Objects

Mentioned In: T304121: Use different messages for labelling Add template buttons

Event Timeline

ECohen_WMDE created this task.Jun 22 2022, 7:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2022, 7:20 AM

ECohen_WMDE moved this task from Backlog to Ready for story time on the WMDE-Templates-FocusArea board.Jun 22 2022, 7:20 AM

ECohen_WMDE attached a referenced file: F35262625: Screen Shot 2022-06-22 at 09.15.53.png. (Show Details)Jun 22 2022, 7:23 AM

ECohen_WMDE attached a referenced file: F35262623: Screen Shot 2022-06-22 at 09.15.10.png. (Show Details)

Maintenance_bot added a project: VisualEditor.Jun 22 2022, 7:29 AM

ECohen_WMDE merged a task: T311113: Parameter name input field shrinks to an almost unusable size.Jun 22 2022, 8:41 AM

ECohen_WMDE added subscribers: thiemowmde, awight.

@ECohen_WMDE, is this only for the mobile view, or should the buttons always say "Add", no matter in which context they appear?

@thiemowmde Good question. This change would affect all views/contexts, not only mobile - I'll add to the requirements so it's clear.

Also responding to a question that came up in story time: should we add a min-width to the input field?

I don't think so, since currently the input shrinking is how the OOUI component adapts to smaller screens. If we set a minimum-width, then the button would have to adapt if the label too long to fit (either by wrapping underneath the field or adding a line break within the word, increasing the height of the button/field). While a small input is not ideal, the component design doesn't work well with these other options either. Hopefully this change decreases the severity of the problem. I tested with german (Hinzufügen) and the input still allows for ~25 characters to be visible at one time.

ECohen_WMDE updated the task description. (Show Details)Jun 23 2022, 9:12 AM

Lena_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.Jun 28 2022, 1:41 PM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 30 2022, 3:27 PM

awight claimed this task.Jul 5 2022, 11:47 AM

awight moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.

awight added a project: WMDE-TechWish-Sprint-2022-06-22.

awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-22 board.

Change 811286 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/VisualEditor@master] Shorten text for add buttons

https://gerrit.wikimedia.org/r/811286

gerritbot added a project: Patch-For-Review.Jul 5 2022, 11:51 AM

awight removed awight as the assignee of this task.Jul 5 2022, 11:52 AM

awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-06-22 board.

WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-06-22 board.Jul 5 2022, 12:43 PM

WMDE-Fisch set the point value for this task to 1.

Change 811286 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Shorten text for add buttons

https://gerrit.wikimedia.org/r/811286

Maintenance_bot removed a project: Patch-For-Review.Jul 5 2022, 1:30 PM

Sidebar "Add template" and header for the add template section should still use the long label.

awight added a project: WMDE-TechWish-Sprint-2022-07-06.Jul 6 2022, 8:32 AM

Andrew-WMDE claimed this task.Jul 6 2022, 10:09 AM

Andrew-WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-07-06 board.

Change 811685 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/VisualEditor@master] Use "Add template" label in the sidebar and as the header

https://gerrit.wikimedia.org/r/811685

gerritbot added a project: Patch-For-Review.Jul 6 2022, 10:48 AM

Andrew-WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 6 2022, 10:55 AM

WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2022-07-06 board.Jul 6 2022, 11:34 AM

Change 811685 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use "Add template" label in the sidebar and as the header

https://gerrit.wikimedia.org/r/811685

Maintenance_bot removed a project: Patch-For-Review.Jul 6 2022, 12:30 PM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 12 2022, 2:01 AM

Lena_WMDE closed this task as Resolved.Jul 19 2022, 8:15 AM

Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-07-06 board.

Pols12 mentioned this in T304121: Use different messages for labelling Add template buttons.Dec 20 2022, 3:53 PM

	F35262625: Screen Shot 2022-06-22 at 09.15.53.png
	Jun 22 2022, 7:20 AM

	F35262623: Screen Shot 2022-06-22 at 09.15.10.png
	Jun 22 2022, 7:20 AM

Shorten "add parameter" and "add template" button labels (VE template dialog)Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Shorten "add parameter" and "add template" button labels (VE template dialog)
Closed, ResolvedPublic1 Estimated Story Points
Actions