Page MenuHomePhabricator
Create Task
Maniphest T311114

Add undocumented parameter input is missing description on mobile (VE template dialog)
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Open template with undocumented parameters in template dialog while on mobile (minerva and narrow screen)
  • Click "add undocumented parameter" button to open the component

What happens?:
Description is missing

What should have happened instead?:
Description should be visible

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Tested on desktop in chrome in minerva with small screen and on iOS with Safari

Event Timeline

ECohen_WMDE created this task.Jun 22 2022, 8:49 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJun 22 2022, 8:49 AM
ECohen_WMDE moved this task from Backlog to Ready for story time on the WMDE-Templates-FocusArea board.Jun 22 2022, 8:49 AM
Maintenance_bot added a project: VisualEditor.Jun 22 2022, 9:29 AM
thiemowmde subscribed.Jun 22 2022, 12:51 PM

I can confirm this. The culprit is a CSS selector .ve-ui-mwTransclusionDialog-collapsed .oo-ui-bookletLayout .oo-ui-fieldsetLayout > .oo-ui-labelElement-label that sets display: none. This is probably meant to target something else, but not this label.

Lena_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.Jun 23 2022, 8:36 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jun 30 2022, 3:27 PM
awight claimed this task.Jul 5 2022, 12:04 PM
awight moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
awight added a project: WMDE-TechWish-Sprint-2022-06-22.
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-06-22 board.
awight removed awight as the assignee of this task.Jul 5 2022, 12:14 PM
awight moved this task from Doing to Demo on the WMDE-TechWish-Sprint-2022-06-22 board.
awight subscribed.

Looks like this was already fixed, although the comments above make it look like the problem may have actually been with the "narrow mode" when the sidebar was collapsed, and not the "mobile skin"?

Vector:

image.png (164×611 px, 23 KB)

Minerva:

image.png (145×1 px, 26 KB)

Desktop narrow mode:

image.png (180×516 px, 23 KB)

awight closed this task as Resolved.Jul 6 2022, 8:12 AM
awight claimed this task.
awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-06-22 board.
WMDE-Fisch set the point value for this task to 0.Jul 6 2022, 11:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL