Page MenuHomePhabricator
Create Task
Maniphest T311150

Show image attribution on Story page (no-js)
Closed, ResolvedPublic
Actions

Description

Same design as on the story builder and viewer (as below) but the code will have to be duplicated since this is nojs.

image.png (128×756 px, 90 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Wikistoriesmaster+195 -58Add image attribution to no-js renderer
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT318905 Knowledge Reliability on Wikistories
 ResolvedeamedinaT311150 Show image attribution on Story page (no-js)

Event Timeline

SBisson created this task.Jun 22 2022, 2:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2022, 2:55 PM
SBisson moved this task from Backlog to R2 on the Wikistories board.Jun 29 2022, 2:45 PM
SBisson edited projects, added Wikistories (R2); removed Wikistories.
Bennylin added a subscriber: Bennylin.Jul 1 2022, 11:40 AM
SBisson edited projects, added Inuka-Team (Kanban); removed Inuka-Team.Jul 21 2022, 3:36 PM
SBisson triaged this task as Medium priority.Jul 22 2022, 1:21 PM
SBisson moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.
SBisson updated the task description. (Show Details)
eamedina claimed this task.Jul 22 2022, 2:07 PM
eamedina moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
eamedina updated the task description. (Show Details)Jul 22 2022, 7:04 PM
gerritbot added a comment.Jul 27 2022, 2:10 AM

Change 817404 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] [WIP] Add image attribution to no-js renderer

https://gerrit.wikimedia.org/r/817404

gerritbot added a project: Patch-For-Review.Jul 27 2022, 2:10 AM
SBisson merged a task: T313949: Include attributions in the No JS page.Jul 27 2022, 4:35 PM
SBisson added a subscriber: • EUdoh-WMF.
eamedina moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Aug 3 2022, 8:37 PM
SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Aug 8 2022, 6:17 PM
gerritbot added a comment.Aug 8 2022, 6:19 PM

Change 817404 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Add image attribution to no-js renderer

https://gerrit.wikimedia.org/r/817404

Maintenance_bot removed a project: Patch-For-Review.Aug 8 2022, 6:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 8 2022, 7:00 PM
• EUdoh-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.Aug 9 2022, 2:00 PM
  • Attribution is present.
  • Clicking on any icon opens the image in Commons, on a new tab.

image.png (1×1 px, 1 MB)

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Aug 17 2022, 9:02 AM
PWaigi-WMF added a parent task: T318905: Knowledge Reliability on Wikistories.Sep 29 2022, 8:33 AM
PWaigi-WMF closed this task as Resolved.Sep 29 2022, 5:07 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL