Page MenuHomePhabricator
Create Task
Maniphest T311151

🟧️ Change EditMetadataValidator to validate the edit summary length
Closed, ResolvedPublic
Actions

Description

  • find out the allowed limit of edit summaries on the wiki
  • pass the limit to the EditMetadataValidator constructor and validate accordingly
  • respond with 400 in case of validation failure: error code comment-too-long in case of max length violation error message "Comment must not be longer than {LIMIT} characters."

Details

SubjectRepoBranchLines +/-
REST: Validate length of user provided commentmediawiki/extensions/Wikibasemaster+81 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Jun 22 2022, 3:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2022, 3:21 PM
Silvan_WMDE claimed this task.Jun 28 2022, 6:21 AM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 9) board.
gerritbot added a comment.Jun 28 2022, 2:36 PM

Change 809189 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Validate length of user provided comment

https://gerrit.wikimedia.org/r/809189

gerritbot added a project: Patch-For-Review.Jun 28 2022, 2:36 PM
Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 9) board.Jun 28 2022, 3:07 PM
gerritbot added a comment.Jul 1 2022, 2:35 PM

Change 809189 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate length of user provided comment

https://gerrit.wikimedia.org/r/809189

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 9) board.Jul 1 2022, 3:07 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 1 2022, 3:30 PM
WMDE-leszek closed this task as Resolved.Jul 11 2022, 9:18 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 11:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL