Page MenuHomePhabricator
Create Task
Maniphest T311163

Replace hardcoded performTest response with makeResultEnvelope and a specific error type
Closed, ResolvedPublic
Actions

Description

In performTest.js, when the test fails, the returned object is a hardcoded Z22 with a hardcoded error. This needs to change to:

  • makeMappedResultEnvelope, and
  • normalError error constructor, with a specific error type for these cases

Completion criteria:

  • function-schemata:
    • creation of new error type in function-schemata data/definitions and errors.js
  • function-orchestrator:
    • update performTest to return this error type
    • add performTest specific tests that check return object when test fails
  • wikilambda:
    • add errortype id to ZErrorTypeRegistry
    • modify front-end in case the response is used or displayed
  • Documentation:
    • Update Representation of errors page with the new reserved error type Zid

Details

SubjectRepoBranchLines +/-
Replace Z10 hardcoded in performTest error with Z512 errormediawiki/services/function-orchestratormaster+111 -27
Update function-schemata sub-module to HEAD (d056b60)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (d056b60)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (d056b60)mediawiki/services/function-evaluatormaster+1 -1
Repurpose Z512 to test failed errormediawiki/services/function-schematamaster+19 -3
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Jun 22 2022, 5:26 PM
DVrandecic moved this task from To triage to Phase θ – Throttling on the Abstract Wikipedia team board.Jun 28 2022, 6:38 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase θ – Throttling); removed Abstract Wikipedia team.
DVrandecic moved this task from Incoming to Needs discussion/DoD on the Abstract Wikipedia team (Phase θ – Throttling) board.Jun 28 2022, 6:44 PM
gerritbot added a comment.Jun 30 2022, 8:17 AM

Change 809909 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/services/function-orchestrator@master] [WIP] Replace Z10 hardcoded in performTest error with Z512 error

https://gerrit.wikimedia.org/r/809909

gerritbot added a project: Patch-For-Review.Jun 30 2022, 8:17 AM

Change 809910 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/services/function-schemata@master] Repurpose Z512 to test failed error

https://gerrit.wikimedia.org/r/809910

gerritbot added a comment.Jun 30 2022, 2:58 PM

Change 809910 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Repurpose Z512 to test failed error

https://gerrit.wikimedia.org/r/809910

gengh mentioned this in rMSFSd056b6016d8e: Repurpose Z512 to test failed error.Jun 30 2022, 2:58 PM
gerritbot added a comment.Jun 30 2022, 3:33 PM

Change 810023 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (d056b60)

https://gerrit.wikimedia.org/r/810023

gerritbot added a comment.Jun 30 2022, 3:33 PM

Change 810024 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (d056b60)

https://gerrit.wikimedia.org/r/810024

gerritbot added a comment.Jun 30 2022, 3:34 PM

Change 810025 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (d056b60)

https://gerrit.wikimedia.org/r/810025

gerritbot added a comment.Jun 30 2022, 3:55 PM

Change 810023 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (d056b60)

https://gerrit.wikimedia.org/r/810023

gengh mentioned this in rMSFO998c2ac08476: Update function-schemata sub-module to HEAD (d056b60).Jun 30 2022, 3:55 PM
gerritbot added a comment.Jun 30 2022, 3:56 PM

Change 810024 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (d056b60)

https://gerrit.wikimedia.org/r/810024

gengh mentioned this in rMSFE0e4b98b7af3e: Update function-schemata sub-module to HEAD (d056b60).Jun 30 2022, 3:56 PM
gerritbot added a comment.Jun 30 2022, 4:05 PM

Change 810025 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (d056b60)

https://gerrit.wikimedia.org/r/810025

gerritbot added a comment.Jun 30 2022, 4:52 PM

Change 809909 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Replace Z10 hardcoded in performTest error with Z512 error

https://gerrit.wikimedia.org/r/809909

gengh mentioned this in rMSFOc42852eb66ee: Replace Z10 hardcoded in performTest error with Z512 error.Jun 30 2022, 4:52 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 30 2022, 5:29 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 11 2022, 10:01 PM
Jdforrester-WMF closed this task as Resolved.Nov 28 2022, 7:43 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF subscribed.

The last of this was done in T309069: Replace and then retire the perform-test pipeline.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL