Page MenuHomePhabricator

OAuth grant type validation/display improvements
Closed, InvalidPublic

Description

These suggestions were made in a comment on T297888: OAuth v2 client request form ignores default grant type values, which is otherwise resolved. Opening a separate task so the suggestion is not lost when the other task is closed:

  1. fail the form validation when there are no grant types - accepting a dysfunctional consumer definition and putting it in the approvals queue is a waste of everyone's time.
  2. show the grant types in Special:OAuthListConsumers. Missing from there made debugging T297888: OAuth v2 client request form ignores default grant type values hard for non-admins.

Event Timeline

BPirkle moved this task from Must do now to Incoming on the API Platform board.

Where does this happen? There is no way to submit Special:OAuthConsumerRegistration with an empty set of grants.

Where does this happen? There is no way to submit Special:OAuthConsumerRegistration with an empty set of grants.

I don't think it does anymore - the forms were changed since this task was created . And I wasn't able to reproduce this anymore on my local. See T297888: OAuth v2 client request form ignores default grant type values for how it was previously possible, and specifically see your comment on that task, which was made before that task was resolved.

I'm going to close this as invalid. Feel free to reopen if you think the remaining item, showing the grant types in Special:OAuthListConsumers, is still something we should do.