Page MenuHomePhabricator
Create Task
Maniphest T311188

ProcessDialogs: Navigation bar is 2px to short
Closed, ResolvedPublic
Actions

Description

Current status

The buttons are 42px high on desktop, but the bar is limited to 40px. Leading to weird appearance when focussed

image.png (348×816 px, 41 KB)

Criteria for done

  • Increase title/navigation bar to 42px similar to footer bar.
    • While there, change min-height value of bar to px, which is better clearing UX criteria

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.44.1mediawiki/coremaster+1 K -822
WikimediaUI theme: Fix height of ProcessDialog's navigation baroojs/uimaster+1 -1
Customize query in gerrit

Event Timeline

Volker_E created this task.Jun 23 2022, 1:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2022, 1:11 AM
gerritbot added a comment.Jun 23 2022, 1:30 AM

Change 807659 had a related patch set uploaded (by VolkerE; author: VolkerE):

[oojs/ui@master] WikimediaUI theme: Fix height of ProcessDialog's navigation bar

https://gerrit.wikimedia.org/r/807659

gerritbot added a project: Patch-For-Review.Jun 23 2022, 1:30 AM
gerritbot added a comment.Jun 24 2022, 10:13 PM

Change 807659 merged by jenkins-bot:

[oojs/ui@master] WikimediaUI theme: Fix height of ProcessDialog's navigation bar

https://gerrit.wikimedia.org/r/807659

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2022, 10:30 PM
gerritbot added a comment.Jul 13 2022, 1:35 PM

Change 813630 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.44.1

https://gerrit.wikimedia.org/r/813630

gerritbot added a project: Patch-For-Review.Jul 13 2022, 1:35 PM
gerritbot added a comment.Jul 13 2022, 3:24 PM

Change 813630 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.44.1

https://gerrit.wikimedia.org/r/813630

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2022, 3:30 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).Jul 13 2022, 4:00 PM
matmarex edited projects, added OOUI (OOUI-0.44.1); removed OOUI.Aug 9 2022, 6:40 PM
Aklapper closed this task as Resolved.Mar 18 2024, 11:47 AM
Aklapper claimed this task.

Assuming this should be resolved. If not, please reopen.

Aklapper removed Aklapper as the assignee of this task.Mar 18 2024, 11:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL