Page MenuHomePhabricator

🟦️ Use the newly created `PermissionChecker` in the AddItemStatement use case
Closed, ResolvedPublic

Description

  • use PermissionChecker (T311154) in the use case after calling the revisionMetadataRetriever
  • return error response if not allowed
  • add e2e test with protected item

Respond with the same kind of error that the MediaWiki framework responds with when then route handler's needsWriteAccess check fails.

Event Timeline

Jakob_WMDE renamed this task from 🟦️ Implement `PermissionChecker` to check if the user can edit the item to 🟦️ Use the newly created `PermissionChecker` in the AddItemStatement use case.Jun 23 2022, 2:05 PM

Change 809929 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Use null username instead of anonymous flag

https://gerrit.wikimedia.org/r/809929

Change 809930 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Use PermissionChecker in AddItemStatement

https://gerrit.wikimedia.org/r/809930

Change 809929 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use null username instead of anonymous flag

https://gerrit.wikimedia.org/r/809929

Change 809930 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use PermissionChecker in AddItemStatement

https://gerrit.wikimedia.org/r/809930