Page MenuHomePhabricator

Fork OutlineControlsWidget
Closed, ResolvedPublic

Description

The new visual editor template dialog sidebar overrides most of the functionality of this class, and the low-level coupling to OutlineSelectWidget is a blocker for removing this dependency. We'll just copy the class and merge in our customizations.

  • Copy OutlineControlsWidget implementation from ooui-js, including the ES and Less files. Inline and hardcode any substituted variables and themed styles.
  • Rename OutlineControlsWidget class to ve.ui.MWTransclusionOutlineControlsWidget
  • CSS classes should be renamed, e.g. oo-ui-outlineControlsWidget
  • i18n messages can stay as they are for now.
  • Switch over the two-pane layout setup to use the new class when initializing this.outlineControlsWidget.

Behavior should be unchanged.

Event Timeline

Change 807525 had a related patch set uploaded (by Svantje Lilienthal; author: Awight):

[mediawiki/extensions/VisualEditor@master] Fork OutlineSelectWidget

https://gerrit.wikimedia.org/r/807525

Change 808856 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Remove dead code (not) selecting first template parameter

https://gerrit.wikimedia.org/r/808856

Change 807525 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fork OutlineControlsWidget

https://gerrit.wikimedia.org/r/807525

Change 808856 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove dead code (not) selecting first template parameter

https://gerrit.wikimedia.org/r/808856

Change 809098 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Simplify OutlineControls CSS a little more

https://gerrit.wikimedia.org/r/809098

Change 809098 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Simplify OutlineControls CSS a little more

https://gerrit.wikimedia.org/r/809098