- Figure out where we use WordLevelDiff, but also consider alternative solutions to understand our way forward.
- The investigation should focus on WordLevelDiff and our possibilities to use it, or, if need be, modifying it, so we could use it. (see this comment for more on this)
- It appears the Tech wishes is using it, so asking Adam or Svantje might be a good option.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Mark WordLevelDiff as newable for now | mediawiki/core | master | +4 -0 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Feature | Lucas_Werkmeister_WMDE | T303317 Show word-level diff for terms and sitelinks in Wikibase diffs | ||
Resolved | Lucas_Werkmeister_WMDE | T311224 Look into best way forward for word-level diff in Wikibase |
Event Timeline
Comment Actions
@Michael and I looked at WordLevelDiff and TableDiffFormatter and concluded that TableDiffFormatter isn’t very useful to us, but marking WordLevelDiff as @newable should be acceptable, under the same conditions as its parent class Diff (namely, that T257472 wants to eventually introduce a factory for it, at which point Diff should no longer be newable).
Comment Actions
Change 810004 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] Mark WordLevelDiff as newable for now
Comment Actions
Change 810004 merged by jenkins-bot:
[mediawiki/core@master] Mark WordLevelDiff as newable for now