Page MenuHomePhabricator

Portal search URLs contain duplicate 'language' parameter
Open, Needs TriagePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Go to www.wikipedia.org
  • Open browser's dev tools to observe network requests
  • Use the search language dropdown menu to choose a language other than English
  • Search for something

What happens?:

The search URL contains duplicate 'language' parameters. For example, selecting 'de' and searching for 'ipad', I observe a request to this URL:

https://www.wikipedia.org/search-redirect.php?family=Wikipedia&language=en&search=ipad&language=de&go=Go

What should have happened instead?:

This currently works as intended because PHP parameter parsing lets the lattermost occurrence 'win', but this behavior is not well-defined and may break in the future. In the future we may sort query parameters lexicographically in the edge cache layer which could cause this to break.